Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all editor text is translated #12407

Closed
joyously opened this issue Nov 29, 2018 · 4 comments
Closed

Not all editor text is translated #12407

joyously opened this issue Nov 29, 2018 · 4 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts

Comments

@joyously
Copy link

Not all editor text is translated
Some of the text in the sidebar and top buttons is translated and some of it is not. And the prompt to "Start writing" is translated on a new post and not on an old post.

To Reproduce

  1. Using WP 4.9.8 and GB 4.5.1
  2. Activate the Pig Latin plugin
  3. Open the editor
  4. See some text is mangled by the plugin, but some text (in sidebar and buttons) is not and should be.

Expected behavior
All text that is output by the editor should be affected by the Pig Latin plugin, although since it is done in javascript, I actually expected that none would be affected. This also brings up the question of whether a PHP plugin like Pig Latin will be able to filter translations for javascript in the new scheme.

Screenshots
editay ostpay local current wp ordpr -5731

editay ostpay local current wp ordpr -4546

@swissspidy
Copy link
Member

Yeah the Pig Latin plugin just doesn‘t support the new JavaScript internationalization functionality in WordPress. Mainly because there‘s no way to override these right now. So it actually can‘t do anything.

The few changed strings you see in the sidebar are all post type and taxonomy labels coming from PHP. That‘s all as expected.

The only question this raises IMO is whether we should add some JS I18N filters to allow overriding strings.

@swissspidy swissspidy added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Nov 29, 2018
@swissspidy
Copy link
Member

@mtias
Copy link
Member

mtias commented Aug 30, 2020

@swissspidy unsure if there is anything pending here?

@swissspidy
Copy link
Member

I think this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

No branches or pull requests

3 participants