-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent use of Block inserter at bottom of page #11909
Comments
WP 5.0-RC1-43944 and this issue is still there |
Issue still exists in 5.0-RC2-43958 |
In the last versions, we tweaked that behavior a little bit. Are you still able to reproduce the issue? |
Yes, I'm still able to reproduce this issue. These first two screens are on the same site. Editing one page, it shows "Start writing or type / to choose a block" at the bottom, whilst editing another page, it doesn't. This page is on another site. Editing this page it shows "Start writing or type / to choose a block" at the bottom, as well as the Plus (+) inserter icon. All three pages end with Paragraph Blocks. |
Thanks for testing @maddisondesigns The difference between the first and the last screenshot is a bug. Right now, we're always showing the text and the icon if the last block is an empty paragraph The second screenshot is expected though because your last block is a paragraph and the paragraph is not empty (so no icon and no text). |
There's no empty Paragraph blocks though. I didn't hit |
Would you mind sharing the HTML content (switch to code editor) of your page? That's indeed very weird. Is it possible that you have a plugin automatically adding empty paragraphs at the end for some reason? |
Here's the content for each of those screens. There's certainly nothing that interesting in the content that should cause this inconsistency, and I definitely don't have any plugins that would automatically add empty paragraph blocks. On the first site (first two screnshots), the plugins are: On the second site (third screenshot):
|
This
is an empty paragraph block, right? |
Hmmm You're right. But why is it saving empty paragraph blocks on the end? If I type (or copy) in a few paragraphs of content, and then happen to hit enter on that last paragraph, it shouldn't just insert a new empty paragraph block. The block should only be inserted when I actually click on it and start typing. |
Technically, it's very hard to make something work like a block but not be a block. Basically you're suggesting like when you first type a character, transform that input into a paragraph. This is challenging for different reasons:
In the end, we don't think it's worth the complexity. |
Sure, I can understand the difficulties with that. If you didn't break everything down into single paragraph blocks, you wouldn't have these issues . The editor shouldn't be auto-inserting blocks into your content. It should be entirely up to the user as to whether they want to insert a block. If the Paragraph block allowed multiple paragraphs of content, then there'd be no reason to auto-insert a new one when hitting Enter, which would also mean this issues wouldn't occur. It would also make editing your content significantly easier because this whole individual paragraph block thing, makes editing text heavy pages a nightmare. |
That's your opinion and a valid one. When we tried multiple paragraphs in a single block initially, feedback suggested that it was confusing for users, when and why to break into separate blocks and how to apply block-level controls to a single paragraph and not the whole block. There are definitely drawbacks for each approach but I think the current one has fewer drawbacks than the previous one. Also, not exactly the right place to discuss this. |
If you tried it initially, then you only tried it amongst yourselves, which means that it was a very tiny audience that came to that decision that it was too confusing. Ever since the Gutenberg plugin was first released, which is basically when the wider WP community first heard about Gutenberg, and was able to try it, the Paragraph block has only ever supported a single paragraph. I've been testing this thing from day one, and it's never allowed more than one paragraph. But you're right, this is not the place. It's obviously not going to change now. Feel free to close this if you'd like as those blank paragraph blocks seem to be the cause of the initial issue I raised. |
Gutenberg was developped in the open from the get go. It is true that the audiance was smaller in the beginning that doesn't mean the feedback was not valuable. As you can see here's the PR that introduced the bahavior #1078 (comment) and the decision was validated after the fact, after testing it. |
There are a lot of decisions I personally don't agree with and in a project this big, it's not easy to make decisions, we do our best by prototyping, testing, discussing and moving forward (disagree and commit). Thank you for the thorough discussion. Keep the feedback coming. It's heard and acknowledged and acted upon if necessary. |
Describe the bug
You've repeatedly said that the block inserter wont appear at the bottom of the page if the last block is a Paragraph Block. I have two sites that are both running the same version of WP 5.0 and I've activated TwentyNineteen.
I've opened up a page on each site. Both pages have a Paragraph Block as the last block. One site shows the block inserter at the bottom of the page, one site doesn't.
On the site where it is showing, if I switch to TwentySeventeen and open the same page, the block inserter still shows at the bottom of the page.
On the site where it isn't showing, if I switch to TwentySeventeen (or even my own theme), the block inserter doesn't show.
Just to confirm that they are running identical WP versions
Site 1:
Site 2:
Site 1: Block inserter doesn't show
Site 2: Block inserter does show
And just to show that both have the same options enabled/disabled
Site 1:
Site 2:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I expect two identical versions of WordPress, running the exact same theme, to work identically
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: