Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tests: Transform embeddable URLs in Audio/Video/Image to Embed Block #11901

Closed
Soean opened this issue Nov 15, 2018 · 2 comments · Fixed by #13997
Closed

Add Tests: Transform embeddable URLs in Audio/Video/Image to Embed Block #11901

Soean opened this issue Nov 15, 2018 · 2 comments · Fixed by #13997
Assignees
@draganescu
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality

Comments

@Soean
Copy link
Member

Soean commented Nov 15, 2018

Description
In #11472 and #11410 we added the transformation to embed block if the user tires to insert embeddable URLs in Audio/Video/Image blocks. Examples: youtube, soundcloud or instagram.
We should add E2E tests to verify the functionality.

See: #11472 (review)
@Soean Soean mentioned this issue Nov 15, 2018
Merged
@tofumatt tofumatt added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality labels Nov 15, 2018
@draganescu
Copy link
Contributor

I'll take a stab at this as a first attempt to get used to e2e tests :)

@draganescu draganescu self-assigned this Feb 21, 2019
@draganescu draganescu mentioned this issue Feb 21, 2019
Merged
5 tasks
@draganescu
Copy link
Contributor

Hey @Soean I've added the PR #13997 with three new tests for the transforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test transform from media to embed blocks WordPress/gutenberg
3 participants
@tofumatt @draganescu @Soean