Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS coding standards: use numeric values for font weights #11687

Closed
afercia opened this issue Nov 9, 2018 · 0 comments · Fixed by #11715
Closed

CSS coding standards: use numeric values for font weights #11687

afercia opened this issue Nov 9, 2018 · 0 comments · Fixed by #11715
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality

Comments

@afercia
Copy link
Contributor

afercia commented Nov 9, 2018

Quoting from the current WordPress CSS coding standards:
https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/

Font weights should be defined using numeric values

As of now, in Gutenberg I can count 7 occurrences of bold. It should be changed to 600 which is the value core uses.

There are also 5 occurrences of normal: it should be changed to 400.
@afercia afercia added [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Code Quality Issues or PRs that relate to code quality labels Nov 9, 2018
@Rahmon Rahmon mentioned this issue Nov 10, 2018
Merged
4 tasks
This was referenced Nov 18, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSS coding standards for font-weight Rahmon/gutenberg
1 participant
@afercia