Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Initialize blocks state by RESET_BLOCKS #11641

Open
aduth opened this issue Nov 8, 2018 · 2 comments
Open

Editor: Initialize blocks state by RESET_BLOCKS #11641

aduth opened this issue Nov 8, 2018 · 2 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@aduth
Copy link
Member

aduth commented Nov 8, 2018

Currently, blocks state is "reset" in response to two separate actions RESET_BLOCKS and SETUP_EDITOR_STATE.

gutenberg/packages/editor/src/store/reducer.js

Lines 292 to 293 in 005c790

case 'RESET_BLOCKS':
case 'SETUP_EDITOR_STATE':

gutenberg/packages/editor/src/store/reducer.js

Lines 395 to 396 in 005c790

case 'RESET_BLOCKS':
case 'SETUP_EDITOR_STATE':

If possible, we should seek to refactor the SETUP_EDITOR effect handler to dispatch resetBlocks directly such that it would only be necessary to cover the RESET_BLOCKS action type from the reducer.
@aduth aduth added [Type] Task Issues or PRs that have been broken down into an individual action to take [Type] Code Quality Issues or PRs that relate to code quality [Package] Editor /packages/editor labels Nov 8, 2018
This was referenced Nov 8, 2018
Closed
Merged
@paaljoachim
Copy link
Contributor

I see one closed PR and one merged PR.

Should this issue be closed?

@WordPress/gutenberg-core

@talldan talldan added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jan 19, 2021
@talldan
Copy link
Contributor

talldan commented Jan 19, 2021

It's very low priority, but can stay open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Package] Editor /packages/editor [Type] Code Quality Issues or PRs that relate to code quality [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@talldan @aduth @paaljoachim