Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper use of setState #1117

Closed
BE-Webdesign opened this issue Jun 11, 2017 · 0 comments · Fixed by #1158 · May be fixed by MaxMood96/gutenberg#99
Closed

Improper use of setState #1117

BE-Webdesign opened this issue Jun 11, 2017 · 0 comments · Fixed by #1158 · May be fixed by MaxMood96/gutenberg#99
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@BE-Webdesign
Copy link
Contributor

I think I accidentally added this one in 🙃 :

In editor/inserter/index.js toggle() is currently:

toggle() {
	this.setState( {
		opened: ! this.state.opened,
	} );
}

It should instead be:

toggle() {
	this.setState( ( previousState ) => ( {
		opened: ! previousState.opened,
	} ) );
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
1 participant