Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dev environment - Use unminified version of react #11126

Closed
mrmadhat opened this issue Oct 26, 2018 · 6 comments
Closed

Local dev environment - Use unminified version of react #11126

mrmadhat opened this issue Oct 26, 2018 · 6 comments
Labels
Needs Technical Feedback Needs testing from a developer perspective. Needs Testing Needs further testing to be confirmed. [Type] Build Tooling Issues or PRs related to build tooling

Comments

@mrmadhat
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running the local development environment via ./bin/setup-local-env.sh wordpress uses the minified version of react so errors display the following

"Error: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings."

Describe the solution you'd like
When using the local dev environment it should use the unminified version of React

@designsimply designsimply added [Type] Build Tooling Issues or PRs related to build tooling Needs Testing Needs further testing to be confirmed. Needs Technical Feedback Needs testing from a developer perspective. labels Oct 26, 2018
@nerrad
Copy link
Contributor

nerrad commented Nov 6, 2018

I can confirm that with SCRIPT_DEBUG set to true all the scripts in wp-includes/script-loader.php::wp_default_packages_vendor are not concatenated but are loading *.min (in WP 5.0b3). It looks like wp_scripts_get_suffix( 'dev' ); ends up always returning the .min suffix.

@nerrad
Copy link
Contributor

nerrad commented Nov 6, 2018

Looks to be related maybe? https://core.trac.wordpress.org/ticket/45156

@mrmadhat
Copy link
Contributor Author

mrmadhat commented Nov 7, 2018

I'm not sure if it is related, if you install the Gutenberg plugin on a normal wp install the non minified version is available.

Here's an example where I've used import incorrectly on a vvv site that shows the correct errors:

image

@gziolo
Copy link
Member

gziolo commented Jan 31, 2019

https://core.trac.wordpress.org/ticket/45156 was fixed, is it still an issue with WordPress 5.0.3?

@nerrad
Copy link
Contributor

nerrad commented Jan 31, 2019

Things are working okay for me against 5.0.3 now.

@gziolo
Copy link
Member

gziolo commented Jan 31, 2019

This means we can close this one, thanks for checking @nerrad 🙇

@gziolo gziolo closed this as completed Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Technical Feedback Needs testing from a developer perspective. Needs Testing Needs further testing to be confirmed. [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

4 participants