Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RichText: deprecate RichText.isEmpty #10763

Closed
ellatrix opened this issue Oct 18, 2018 · 4 comments
Closed

RichText: deprecate RichText.isEmpty #10763

ellatrix opened this issue Oct 18, 2018 · 4 comments
Assignees
@ellatrix
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.

Comments

@ellatrix
Copy link
Member

Since our new RichText value is just a string, we should probably get rid of this API altogether and do a simpler check. This also involves looking to see if we can return an empty string for empty multiline values, instead of e.g. <p></p>, see #10678 (comment).
@ellatrix ellatrix added [Feature] Block API API that allows to express the block paradigm. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels Oct 18, 2018
@ellatrix ellatrix added this to the 4.2 - API freeze milestone Oct 18, 2018
@ellatrix ellatrix self-assigned this Oct 18, 2018
@youknowriad youknowriad modified the milestones: 4.2, WordPress 5.0 Oct 27, 2018
@ellatrix ellatrix mentioned this issue Oct 29, 2018
Merged
4 tasks
@mtias
Copy link
Member

mtias commented Nov 1, 2018

Wouldn't controlling the interface give us more flexibility going forward?

@ellatrix
Copy link
Member Author

ellatrix commented Nov 1, 2018

Tbh I'm fine with checking the value directly. Do we plan on ever switching away from HTML again?

@mtias
Copy link
Member

mtias commented Nov 1, 2018 •
edited
Loading

Do we plan on ever switching away from HTML again?

Who knows! :)

@ellatrix ellatrix added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement. labels Jan 29, 2019
@ellatrix ellatrix mentioned this issue Feb 8, 2019
Closed
17 tasks
This was referenced Feb 28, 2019
Closed
Closed
@ellatrix ellatrix removed this from the WordPress 5.x milestone Jun 27, 2019
@ellatrix
Copy link
Member Author

Let's close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @mtias @ellatrix