Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Media Button #10280

Closed
Johnnyface opened this issue Oct 1, 2018 · 5 comments
Closed

Insert Media Button #10280

Johnnyface opened this issue Oct 1, 2018 · 5 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Help Request Help with setup, implementation, or "How do I?" questions.

Comments

@Johnnyface
Copy link

The classic WordPress editor had an insert media button which was convenient for those of us who include a lot of PDFs and other non-image file/document links on our pages.

Previously, I could upload a pdf or word doc. Select text. Click ADD MEDIA and select the document from my media library and I was done.

NOW I have to upload the document, look at the attachment details, copy the URL to the doc. Go back to edit the page or post, select the text. Click link. Insert the link, apply the change, then modify the link to make sure it opens in a new tab/window. It's a lot more work.

The fix would be to return the add media function as had in the old editor, or make the new add image function be able to cope with pdfs and other non-image documents to simplify the process for us. OR, if I'm an idiot and missing a much simpler way to do this with Gutenberg, make it a more obvious feature so us olds don't thrash looking for it.

kthnxbai.

@Soean Soean added the [Feature] Media Anything that impacts the experience of managing media label Oct 1, 2018
@ajitbohra ajitbohra added the [Type] Help Request Help with setup, implementation, or "How do I?" questions. label Oct 2, 2018
@ajitbohra
Copy link
Member

@Johnnyface same can be achieved using file block you can add/link non-image documents.

@Johnnyface
Copy link
Author

I appreciate the response. The File Block is still a comparatively awkward tool when all you really need to do is create a text link to open a pdf or whatever in a new tab or window.

@ajitbohra ajitbohra reopened this Oct 2, 2018
@chrisvanpatten
Copy link
Contributor

It sounds like this may be a case where the upcoming format library could be re-used, similar to what we have for inline image support?

@mintplugins
Copy link

Related: #8322

@chrisvanpatten
Copy link
Contributor

Thanks @mintplugins — since that ticket has some extra context and discussion I'll close this out in favor of #8322!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Help Request Help with setup, implementation, or "How do I?" questions.
Projects
None yet
Development

No branches or pull requests

5 participants