From 7b895a7139d51fc8bf8720258b80931625f591e7 Mon Sep 17 00:00:00 2001 From: Grzegorz Ziolkowski Date: Tue, 9 Jan 2018 10:02:10 +0100 Subject: [PATCH 1/3] Enforce using the latest LTS version (8.x) of Node and up --- .travis.yml | 1 - CONTRIBUTING.md | 2 +- package-lock.json | 88 +++++++++++++++++++++++++++++++++++++++++++++++ package.json | 7 +++- 4 files changed, 95 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index e9db6ebc0ffc7..4aa53fbfb884b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,7 +2,6 @@ sudo: false language: node_js node_js: - '8' - - '6' script: - npm run test:coverage-ci diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1a1beba0a99f1..be4e2d7349188 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ You can pick among all the =8.0.0", + "npm": ">=5.0.0" + }, "devDependencies": { "babel-core": "^6.25.0", "babel-loader": "^7.1.1", "babel-plugin-transform-object-rest-spread": "^6.23.0", "babel-preset-env": "^1.5.2", "chalk": "^2.0.1", + "check-node-version": "^3.1.1", "codecov": "^2.2.0", "glob": "^7.1.2", "jest": "^22.0.3", @@ -25,7 +30,7 @@ "scripts": { "build-clean": "rimraf ./packages/*/build ./packages/*/build-module", "build": "node ./scripts/build.js", - "postinstall": "lerna bootstrap && npm run build", + "postinstall": "lerna bootstrap && check-node-version --package && npm run build", "test": "jest", "test:coverage": "jest --coverage", "test:coverage-ci": "jest --coverage && codecov", From daf94907760563ab32fa6b01b686e47f928a0ba6 Mon Sep 17 00:00:00 2001 From: Grzegorz Ziolkowski Date: Tue, 9 Jan 2018 12:57:05 +0100 Subject: [PATCH 2/3] Move node version check to prebuild run script --- package.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 46f44cb138b4b..017cb872357bb 100644 --- a/package.json +++ b/package.json @@ -29,8 +29,9 @@ }, "scripts": { "build-clean": "rimraf ./packages/*/build ./packages/*/build-module", + "prebuild": "check-node-version --package", "build": "node ./scripts/build.js", - "postinstall": "lerna bootstrap && check-node-version --package && npm run build", + "postinstall": "lerna bootstrap && npm run build", "test": "jest", "test:coverage": "jest --coverage", "test:coverage-ci": "jest --coverage && codecov", From 75251a4a5c91edcfbd232dc9166388e4d4ebfa58 Mon Sep 17 00:00:00 2001 From: Stephen Edgar Date: Tue, 9 Jan 2018 23:03:21 +1100 Subject: [PATCH 3/3] Remove superfluous `a` and use full Node.js name --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index be4e2d7349188..d0e95c5b8fa95 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,7 +16,7 @@ You can pick among all the