Block Library: Button: Remove title attribute handling

WordPress · Jan 31, 2020 · e4b8957 · e4b8957
1 parent 6aa9944
commit e4b8957
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 22 deletions.
diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -2,7 +2,6 @@
  * External dependencies
  */
 import classnames from 'classnames';
-import { escape } from 'lodash';
 
 /**
  * WordPress dependencies
@@ -77,14 +76,7 @@ function BorderPanel( { borderRadius = '', setAttributes } ) {
 	);
 }
 
-function URLPicker( {
-	isSelected,
-	url,
-	title,
-	setAttributes,
-	opensInNewTab,
-	onToggleOpenInNewTab,
-} ) {
+function URLPicker( { isSelected, url, setAttributes, opensInNewTab, onToggleOpenInNewTab } ) {
 	const [ isURLPickerOpen, setIsURLPickerOpen ] = useState( false );
 	const openLinkControl = () => {
 		setIsURLPickerOpen( true );
@@ -93,16 +85,9 @@ function URLPicker( {
 		<Popover position="bottom center" onClose={ () => setIsURLPickerOpen( false ) }>
 			<LinkControl
 				className="wp-block-navigation-link__inline-link-input"
-				value={ { url, title, opensInNewTab } }
-				onChange={ ( {
-					title: newTitle = '',
-					url: newURL = '',
-					opensInNewTab: newOpensInNewTab,
-				} ) => {
-					setAttributes( {
-						title: escape( newTitle ),
-						url: newURL,
-					} );
+				value={ { url, opensInNewTab } }
+				onChange={ ( { url: newURL = '', opensInNewTab: newOpensInNewTab } ) => {
+					setAttributes( { url: newURL } );
 
 					if ( opensInNewTab !== newOpensInNewTab ) {
 						onToggleOpenInNewTab( newOpensInNewTab );
@@ -149,7 +134,7 @@ function ButtonEdit( {
 	className,
 	isSelected,
 } ) {
-	const { borderRadius, linkTarget, placeholder, rel, text, title, url } = attributes;
+	const { borderRadius, linkTarget, placeholder, rel, text, url } = attributes;
 	const onSetLinkRel = useCallback(
 		( value ) => {
 			setAttributes( { rel: value } );
@@ -178,7 +163,7 @@ function ButtonEdit( {
 	const { gradientClass, gradientValue, setGradient } = __experimentalUseGradient();
 
 	return (
-		<div className={ className } title={ title }>
+		<div className={ className }>
 			<RichText
 				placeholder={ placeholder || __( 'Add text…' ) }
 				value={ text }
@@ -201,7 +186,6 @@ function ButtonEdit( {
 				} }
 			/>
 			<URLPicker
-				title={ title }
 				url={ url }
 				setAttributes={ setAttributes }
 				isSelected={ isSelected }

diff --git a/packages/block-library/src/button/save.js b/packages/block-library/src/button/save.js
@@ -50,6 +50,10 @@ export default function save( { attributes } ) {
 		borderRadius: borderRadius ? borderRadius + 'px' : undefined,
 	};
 
+	// The use of a `title` attribute here is soft-deprecated, but still applied
+	// if it had already been assigned, for the sake of backward-compatibility.
+	// A title will no longer be assigned for new or updated button block links.
+
 	return (
 		<div>
 			<RichText.Content