From e44a64066a6472b2db53be793a4976d813565d82 Mon Sep 17 00:00:00 2001 From: Kerry Liu Date: Fri, 12 Mar 2021 15:12:13 -0800 Subject: [PATCH] E2E: stabilize failing tests in trunk (#29836) --- .../editor/various/adding-blocks.test.js | 12 +++++----- .../experiments/navigation-editor.test.js | 23 ++++++------------- 2 files changed, 13 insertions(+), 22 deletions(-) diff --git a/packages/e2e-tests/specs/editor/various/adding-blocks.test.js b/packages/e2e-tests/specs/editor/various/adding-blocks.test.js index 378503b5a152d..e3118e94ae444 100644 --- a/packages/e2e-tests/specs/editor/various/adding-blocks.test.js +++ b/packages/e2e-tests/specs/editor/various/adding-blocks.test.js @@ -290,14 +290,14 @@ describe( 'adding blocks', () => { inserterMenuInputSelector ); inserterMenuSearchInput.type( 'cover' ); - // We need to wait a bit after typing otherwise we might an "early" result - // that is going to be "detached" when trying to click on it - // eslint-disable-next-line no-restricted-syntax - await page.waitForTimeout( 200 ); - const coverBlock = await page.waitForSelector( + await page.waitForSelector( '.block-editor-block-types-list .editor-block-list-item-cover' ); - await coverBlock.click(); + // clicking may be too quick and may select a detached node. + await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Tab' ); + await page.keyboard.press( 'Enter' ); + expect( await getEditedPostContent() ).toMatchSnapshot(); } ); diff --git a/packages/e2e-tests/specs/experiments/navigation-editor.test.js b/packages/e2e-tests/specs/experiments/navigation-editor.test.js index 8b700ada66fa5..e593524368492 100644 --- a/packages/e2e-tests/specs/experiments/navigation-editor.test.js +++ b/packages/e2e-tests/specs/experiments/navigation-editor.test.js @@ -347,26 +347,17 @@ describe( 'Navigation editor', () => { ); await startEmptyButton.click(); - // NOTE - the following code is commented out. - // In CI the editor doesn't seem to support variations. - // The following code can be re-introduced once that's resolved. - // Add an inner link block. - // const appender = await page.waitForSelector( - // 'button[aria-label="Add block"]' - // ); - // await appender.click(); + const appender = await page.waitForSelector( + 'button[aria-label="Add block"]' + ); + await appender.click(); // Must be an exact match to the word 'Link' as other // variations also contain the word 'Link'. - // const linkInserterItem = await page.waitForXPath( - // '//button[@role="option"]//span[.="Link"]' - // ); - // await linkInserterItem.click(); - - const appender = await page.waitForSelector( - 'button[aria-label="Add Link"]' + const linkInserterItem = await page.waitForXPath( + '//button[@role="option"]//span[.="Link"]' ); - await appender.click(); + await linkInserterItem.click(); await page.waitForSelector( 'input[aria-label="URL"]' );