Small tweaks

WordPress · Jan 4, 2019 · 860fec0 · 860fec0
1 parent 88897af
commit 860fec0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/editor/src/components/inserter/index.js b/packages/editor/src/components/inserter/index.js
@@ -112,7 +112,7 @@ export default compose( [
 		return {
 			title: getEditedPostAttribute( 'title' ),
 			hasItems: hasInserterItems( rootClientId ),
-			rootClientId: rootClientId || getBlockInsertionPoint().rootClientId,
+			rootClientId,
 		};
 	} ),
 	ifCondition( ( { hasItems } ) => hasItems ),

diff --git a/packages/editor/src/components/inserter/menu.js b/packages/editor/src/components/inserter/menu.js
@@ -372,6 +372,10 @@ export default compose(
 			hideInsertionPoint,
 		} = dispatch( 'core/editor' );
 
+		// To avoid duplication, getInsertionPoint is extracted and used in two event handlers
+		// This breaks the withDispatch not containing any logic rule.
+		// Since it's a function only called when the event handlers are called,
+		// it's fine to extract it.
 		// eslint-disable-next-line no-restricted-syntax
 		function getInsertionPoint() {
 			const {