Fix unit tests and remove isSmall prop

WordPress · Jan 29, 2020 · 67f13d2 · 67f13d2
1 parent f55084f
commit 67f13d2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 18 deletions.
diff --git a/packages/components/src/custom-select-control/README.md b/packages/components/src/custom-select-control/README.md
@@ -84,12 +84,6 @@ Used to visually hide the label. It will always be visible to screen readers.
 - Type: `Boolean`
 - Required: No
 
-#### isSmall
-
-Renders the Select in a smaller size.
-- Type: `Boolean`
-- Required: No
-
 #### label
 
 The label for the control.

diff --git a/packages/components/src/custom-select-control/index.js b/packages/components/src/custom-select-control/index.js
@@ -29,9 +29,9 @@ const stateReducer = (
 			return {
 				selectedItem:
 					items[
-						selectedItem ?
-							Math.min( items.indexOf( selectedItem ) + 1, items.length - 1 ) :
-							0
+						selectedItem
+							? Math.min( items.indexOf( selectedItem ) + 1, items.length - 1 )
+							: 0
 					],
 			};
 		case useSelect.stateChangeTypes.ToggleButtonKeyDownArrowUp:
@@ -40,9 +40,9 @@ const stateReducer = (
 			return {
 				selectedItem:
 					items[
-						selectedItem ?
-							Math.max( items.indexOf( selectedItem ) - 1, 0 ) :
-							items.length - 1
+						selectedItem
+							? Math.max( items.indexOf( selectedItem ) - 1, 0 )
+							: items.length - 1
 					],
 			};
 		default:
@@ -55,7 +55,6 @@ export default function CustomSelectControl( {
 	label,
 	options: items,
 	onChange: onSelectedItemChange,
-	isSmall = true,
 	value: _selectedItem,
 } ) {
 	const {
@@ -105,7 +104,7 @@ export default function CustomSelectControl( {
 					'aria-label': label,
 					'aria-labelledby': undefined,
 					className: 'components-custom-select-control__button',
-					isSmall,
+					isSmall: true,
 				} ) }
 			>
 				{ itemToString( selectedItem ) }

diff --git a/storybook/test/__snapshots__/index.js.snap b/storybook/test/__snapshots__/index.js.snap
@@ -2554,7 +2554,7 @@ exports[`Storyshots Components/CustomSelectControl Default 1`] = `
     aria-expanded={false}
     aria-haspopup="listbox"
     aria-label="Font Size"
-    className="components-button components-custom-select-control__button"
+    className="components-button components-custom-select-control__button is-small"
     id="downshift-null-toggle-button"
     onClick={[Function]}
     onKeyDown={[Function]}
@@ -3092,7 +3092,7 @@ exports[`Storyshots Components/FontSizePicker Default 1`] = `
         aria-expanded={false}
         aria-haspopup="listbox"
         aria-label="Preset Size"
-        className="components-button components-custom-select-control__button"
+        className="components-button components-custom-select-control__button is-small"
         id="downshift-null-toggle-button"
         onClick={[Function]}
         onKeyDown={[Function]}
@@ -3180,7 +3180,7 @@ exports[`Storyshots Components/FontSizePicker With Slider 1`] = `
         aria-expanded={false}
         aria-haspopup="listbox"
         aria-label="Preset Size"
-        className="components-button components-custom-select-control__button"
+        className="components-button components-custom-select-control__button is-small"
         id="downshift-null-toggle-button"
         onClick={[Function]}
         onKeyDown={[Function]}
@@ -3312,7 +3312,7 @@ exports[`Storyshots Components/FontSizePicker Without Custom Sizes 1`] = `
         aria-expanded={false}
         aria-haspopup="listbox"
         aria-label="Preset Size"
-        className="components-button components-custom-select-control__button"
+        className="components-button components-custom-select-control__button is-small"
         id="downshift-null-toggle-button"
         onClick={[Function]}
         onKeyDown={[Function]}