Block Library: Button: Remove title attribute handling

WordPress · Feb 3, 2020 · 670ed98 · 670ed98
1 parent 1e35ca3
commit 670ed98
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/packages/block-library/src/button/edit.js b/packages/block-library/src/button/edit.js
@@ -2,7 +2,6 @@
  * External dependencies
  */
 import classnames from 'classnames';
-import { escape } from 'lodash';
 
 /**
  * WordPress dependencies
@@ -86,7 +85,6 @@ function BorderPanel( { borderRadius = '', setAttributes } ) {
 function URLPicker( {
 	isSelected,
 	url,
-	title,
 	setAttributes,
 	opensInNewTab,
 	onToggleOpenInNewTab,
@@ -102,16 +100,12 @@ function URLPicker( {
 		>
 			<LinkControl
 				className="wp-block-navigation-link__inline-link-input"
-				value={ { url, title, opensInNewTab } }
+				value={ { url, opensInNewTab } }
 				onChange={ ( {
-					title: newTitle = '',
 					url: newURL = '',
 					opensInNewTab: newOpensInNewTab,
 				} ) => {
-					setAttributes( {
-						title: escape( newTitle ),
-						url: newURL,
-					} );
+					setAttributes( { url: newURL } );
 
 					if ( opensInNewTab !== newOpensInNewTab ) {
 						onToggleOpenInNewTab( newOpensInNewTab );
@@ -164,7 +158,6 @@ function ButtonEdit( {
 		placeholder,
 		rel,
 		text,
-		title,
 		url,
 	} = attributes;
 	const onSetLinkRel = useCallback(
@@ -199,7 +192,7 @@ function ButtonEdit( {
 	} = __experimentalUseGradient();
 
 	return (
-		<div className={ className } title={ title }>
+		<div className={ className }>
 			<RichText
 				placeholder={ placeholder || __( 'Add text…' ) }
 				value={ text }
@@ -225,7 +218,6 @@ function ButtonEdit( {
 				} }
 			/>
 			<URLPicker
-				title={ title }
 				url={ url }
 				setAttributes={ setAttributes }
 				isSelected={ isSelected }

diff --git a/packages/block-library/src/button/save.js b/packages/block-library/src/button/save.js
@@ -57,6 +57,10 @@ export default function save( { attributes } ) {
 		borderRadius: borderRadius ? borderRadius + 'px' : undefined,
 	};
 
+	// The use of a `title` attribute here is soft-deprecated, but still applied
+	// if it had already been assigned, for the sake of backward-compatibility.
+	// A title will no longer be assigned for new or updated button block links.
+
 	return (
 		<div>
 			<RichText.Content