From 613b793ee17a2dc2cbdba67f166be121a35c2189 Mon Sep 17 00:00:00 2001
From: Andrew Duthie <andrew@andrewduthie.com>
Date: Tue, 29 Jan 2019 12:05:14 -0500
Subject: [PATCH] Plugin: Deprecate gutenberg_get_script_polyfill (#13536)

---
 .../backward-compatibility/deprecations.md    |  1 +
 lib/client-assets.php                         | 28 +++-------
 phpunit/class-polyfill-test.php               | 54 -------------------
 3 files changed, 8 insertions(+), 75 deletions(-)
 delete mode 100644 phpunit/class-polyfill-test.php

diff --git a/docs/designers-developers/developers/backward-compatibility/deprecations.md b/docs/designers-developers/developers/backward-compatibility/deprecations.md
index 81cd5352a2cfea..6ff124b27a34fa 100644
--- a/docs/designers-developers/developers/backward-compatibility/deprecations.md
+++ b/docs/designers-developers/developers/backward-compatibility/deprecations.md
@@ -57,6 +57,7 @@ The Gutenberg project's deprecation policy is intended to support backward compa
 - The PHP function `gutenberg_toggle_custom_fields` has been removed.
 - The PHP function `gutenberg_collect_meta_box_data` has been removed. Use [`register_and_do_post_meta_boxes`](https://developer.wordpress.org/reference/functions/register_and_do_post_meta_boxes/) instead.
 - `window._wpLoadGutenbergEditor` has been removed. Use `window._wpLoadBlockEditor` instead. Note: This is a private API, not intended for public use. It may be removed in the future.
+- The PHP function `gutenberg_get_script_polyfill` has been removed. Use [`wp_get_script_polyfill`](https://developer.wordpress.org/reference/functions/wp_get_script_polyfill/) instead.
 
 ## 4.5.0
 - `Dropdown.refresh()` has been deprecated as the contained `Popover` is now automatically refreshed.
diff --git a/lib/client-assets.php b/lib/client-assets.php
index 3d5045e3fe67cc..469310edbe118c 100644
--- a/lib/client-assets.php
+++ b/lib/client-assets.php
@@ -43,27 +43,10 @@ function gutenberg_url( $path ) {
  * @return string Conditional polyfill inline script.
  */
 function gutenberg_get_script_polyfill( $tests ) {
-	global $wp_scripts;
-
-	$polyfill = '';
-	foreach ( $tests as $test => $handle ) {
-		if ( ! array_key_exists( $handle, $wp_scripts->registered ) ) {
-			continue;
-		}
-
-		$polyfill .= (
-			// Test presence of feature...
-			'( ' . $test . ' ) || ' .
-			// ...appending polyfill on any failures. Cautious viewers may balk
-			// at the `document.write`. Its caveat of synchronous mid-stream
-			// blocking write is exactly the behavior we need though.
-			'document.write( \'<script src="' .
-			esc_url( $wp_scripts->registered[ $handle ]->src ) .
-			'"></scr\' + \'ipt>\' );'
-		);
-	}
+	_deprecated_function( __FUNCTION__, '5.0.0', 'wp_get_script_polyfill' );
 
-	return $polyfill;
+	global $wp_scripts;
+	return wp_get_script_polyfill( $wp_scripts, $tests );
 }
 
 if ( ! function_exists( 'register_tinymce_scripts' ) ) {
@@ -153,11 +136,14 @@ function gutenberg_register_packages_scripts() {
  * @since 0.1.0
  */
 function gutenberg_register_scripts_and_styles() {
+	global $wp_scripts;
+
 	gutenberg_register_vendor_scripts();
 
 	wp_add_inline_script(
 		'wp-polyfill',
-		gutenberg_get_script_polyfill(
+		wp_get_script_polyfill(
+			$wp_scripts,
 			array(
 				'\'fetch\' in window' => 'wp-polyfill-fetch',
 				'document.contains'   => 'wp-polyfill-node-contains',
diff --git a/phpunit/class-polyfill-test.php b/phpunit/class-polyfill-test.php
deleted file mode 100644
index c64878bd13fb24..00000000000000
--- a/phpunit/class-polyfill-test.php
+++ /dev/null
@@ -1,54 +0,0 @@
-<?php
-/**
- * Test gutenberg_get_script_polyfill()
- *
- * @package Gutenberg
- */
-
-class Polyfill_Test extends WP_UnitTestCase {
-	var $old_wp_scripts;
-
-	function setUp() {
-		parent::setUp();
-		$this->old_wp_scripts = isset( $GLOBALS['wp_scripts'] ) ? $GLOBALS['wp_scripts'] : null;
-		remove_action( 'wp_default_scripts', 'wp_default_scripts' );
-
-		$GLOBALS['wp_scripts'] = new WP_Scripts();
-
-		$GLOBALS['wp_scripts']->default_version = get_bloginfo( 'version' );
-
-		gutenberg_register_scripts_and_styles();
-	}
-
-	public function tearDown() {
-		$GLOBALS['wp_scripts'] = $this->old_wp_scripts;
-		add_action( 'wp_default_scripts', 'wp_default_scripts' );
-		parent::tearDown();
-	}
-
-	function test_gutenberg_get_script_polyfill_ignores_missing_handle() {
-		$polyfill = gutenberg_get_script_polyfill(
-			array(
-				'\'Promise\' in window' => 'promise',
-			)
-		);
-
-		$this->assertEquals( '', $polyfill );
-	}
-
-	function test_gutenberg_get_script_polyfill_returns_inline_script() {
-		wp_register_script( 'promise', 'https://unpkg.com/promise-polyfill/promise.js' );
-
-		$polyfill = gutenberg_get_script_polyfill(
-			array(
-				'\'Promise\' in window' => 'promise',
-			)
-		);
-
-		$this->assertEquals(
-			'( \'Promise\' in window ) || document.write( \'<script src="https://unpkg.com/promise-polyfill/promise.js"></scr\' + \'ipt>\' );',
-			$polyfill
-		);
-	}
-
-}