Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blue Note #19

Merged
merged 10 commits into from
Mar 29, 2023
Merged

Add Blue Note #19

merged 10 commits into from
Mar 29, 2023

Conversation

carolinan
Copy link
Collaborator

@carolinan carolinan commented Mar 10, 2023

Add a rough start for Blue Note.

What's missing:

  1. Font sizes, spacing (if custom)
  2. Detailed templates, sidebar
  3. Screenshot
  4. Categories pattern for Home

Known issues:
The contrast and primary color has the same color code

Description:
Requires at least: 6.1
Tested up to: 6.2
Requires PHP: 8.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 8.0? are we using something specific to have that high a requirement?

Copy link
Collaborator Author

@carolinan carolinan Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but we should encourage users to use a newer PHP version. Consider that the current version of PHP is 8.2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: Create block theme does not support PHP 8, so this should be lowered until the plugin is updated 😞

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My dev env has wp_debug enabled and with PHP 8 I get a ton of warnings that are coming from core. I think in general going with 7 for now should be fine until core updates. In any case, CBT should update as well, I believe I saw an issue raised in their repo about it

blue-note/style.css Outdated Show resolved Hide resolved
<h2 class="wp-block-heading">By Topic</h2>
<!-- /wp:heading -->

<!-- wp:query {"queryId":0,"query":{"perPage":3,"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true},"displayLayout":{"type":"flex","columns":3},"align":"full","layout":{"type":"default"}} -->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not really posts, but categories. How should we show these?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the archive title and the archive description only work on the archive template.
Maybe it is an advanced variation of a category block? Untested.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress/gutenberg#49094 I think this is what we want

blue-note/theme.json Outdated Show resolved Hide resolved
blue-note/theme.json Outdated Show resolved Hide resolved
blue-note/theme.json Outdated Show resolved Hide resolved
@MaggieCabrera
Copy link
Collaborator

Thanks so much for having a go at this! I will do a more thorough review of this on Monday, but it's looking like a great start!

@carolinan
Copy link
Collaborator Author

What is needed in order to commit this as a starting point?

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great starting point, thank you so much @carolinan for getting this one started! Lets open issues and work on the templates and patterns on separate PRs now

@MaggieCabrera MaggieCabrera merged commit a134e5e into trunk Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants