Skip to content
This repository has been archived by the owner on Mar 21, 2023. It is now read-only.

Design Explorations: Installed results that are disabled #14

Open
melchoyce opened this issue Jul 10, 2019 · 15 comments
Open

Design Explorations: Installed results that are disabled #14

melchoyce opened this issue Jul 10, 2019 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@melchoyce
Copy link
Collaborator

What if you search for something a plugin you've downloaded includes, but you've disabled it?

@melchoyce
Copy link
Collaborator Author

melchoyce commented Jul 10, 2019

One idea (that would need copy help):

image

Or, we could reduce the opacity on the disabled result:

image

(The colors exported weird, but that "enable" link is regular link blue)

@kjellr
Copy link

kjellr commented Jul 11, 2019

Would it make sense to have the "Enable" link be a button here?

@melchoyce
Copy link
Collaborator Author

I was worried it'd get noisy if you have a bunch of disabled results, but I'll try mocking it up 👍

@melchoyce
Copy link
Collaborator Author

image

@melchoyce
Copy link
Collaborator Author

Other idea — don't show an enable button at all, and instead turn the block back on if they select one.

@kjellr
Copy link

kjellr commented Jul 11, 2019

This is reminding me a little bit of the problem we ran into over in WordPress/gutenberg#14224.

In the end, we just went with a checkbox, but here are definitely some relevant explorations in the following comments:

@melchoyce
Copy link
Collaborator Author

Related (h/t @karmatosed): WordPress/gutenberg#15121

@mapk
Copy link

mapk commented Jul 11, 2019

@melchoyce I really like the last idea of just showing the blocks without additional links or buttons. The text at the top explains what's going on; "We did find these other disabled blocks." Of course, that might need a copy review.

Once the user selects a block, it's automatically enabled again. 👍

This keeps the Block Inserter (Library) from getting too complicated. Especially in light of the upcoming Block Directory changes, it might begin to get overwhelmed with varrying design patterns.

@melchoyce
Copy link
Collaborator Author

Alright, then we can go straight-forward:

image

@ck-lee
Copy link

ck-lee commented Jul 22, 2019

Hi @melchoyce, I've started to implement this but I hit a road bump.
The issue is, with the way the inserter works, these disabled blocks are actually closer related to "blocks that are not installed" than "blocks that are installed".

For example:

  • If listicle block is installed, but disabled.
  • Typing "list", it is difficult to show listicle as a result among the enabled blocks.
  • If is only when user types "listicle", and no installed (or enabled) blocks found, the block search is then triggered.
  • Then it is easier for us to display the listicles as part of the block search results.

So, can we do something like this for V1?

  • Display "disabled" blocks as part of block search results. (Note: the results may have a mix of disabled and enabled blocks.)
  • For example: image

Or I can hide disabled blocks from the results.

@melchoyce
Copy link
Collaborator Author

Let's hide disabled blocks from results for the v1.

@karmatosed
Copy link
Member

karmatosed commented Aug 20, 2019

Just checking in on the status of this so we can keep this repo synced and updated with issues. @ck-lee is this now implemented?

@karmatosed karmatosed added the enhancement New feature or request label Aug 20, 2019
@StevenDufresne
Copy link

@karmatosed This doesn't appear to be implemented yet.

@StevenDufresne
Copy link

@melchoyce @karmatosed @ck-lee

Is this a problem with the block directory or custom blocks in general? If I manually install a block, then disable it, do I not follow the same path?

The reason why this distinction matters is that the problem that @ck-lee ran into is a problem with the logic in Gutenberg's 'core' library, more specific: the inserter. If that is the case, I think we should consider moving this issue over to the Gutenberg repo.

The Issue that @mapk linked above is related.

@StevenDufresne
Copy link

Disregard my previous comment 😳🙂.

I've had a few chats and I think the block directory is the better place to address this :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants