From 1eab0e85e1e3f9e92dcc7a8e095e6ac3c9243bb2 Mon Sep 17 00:00:00 2001 From: jrfnl Date: Fri, 18 Jun 2021 21:11:18 +0200 Subject: [PATCH 1/2] GH Actions: run tests against PHP 8.1 Now PR 446 has been merged and the PHPUnit version requirements widened, we can start running the tests against PHP 8.1. For the time being - until PHP 8.1 is actually released - these builds are allowed to fail (experimental), though fixing as much as possible as soon as possible, would be a good idea ;-) Fixes 498 --- .github/workflows/test.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a1b859933..3ac076bd7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -32,10 +32,9 @@ jobs: experimental: false # Test against PHP Nightly. - # This should be enabled once the PHPUnit version constraints have been widened. - #- php: '8.1' - # coverage: false - # experimental: true + - php: '8.1' + coverage: false + experimental: true name: "Test: PHP ${{ matrix.php }}" From 1bb0e934921c215dff97ec678abc62d5afeef4bf Mon Sep 17 00:00:00 2001 From: jrfnl Date: Mon, 21 Jun 2021 20:34:22 +0200 Subject: [PATCH 2/2] GH Actions: set error reporting to E_ALL Turns out the default setting for `error_reporting` used by the SetupPHP action is `error_reporting=E_ALL & ~E_DEPRECATED & ~E_STRICT` and `display_errors` is set to `Off`. For the purposes of CI, I'd recommend running with `E_ALL` and `display_errors=On` to ensure **all** PHP notices are shown. --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3ac076bd7..773f8cd66 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -57,6 +57,7 @@ jobs: uses: shivammathur/setup-php@v2 with: php-version: ${{ matrix.php }} + ini-values: error_reporting=-1, display_errors=On, log_errors_max_len=0 coverage: ${{ steps.set_cov.outputs.COV }} tools: cs2pr