Add proxy testing #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds mitmproxy as a requirement, but does not yet use it.
Closed
Conflicts: .travis.yml
This errors out on old PHP.
|
Looks like HTTP proxies are failing on HHVM, yay for testing! |
|
I think I've worked it out! We're using port 9000, but that happens to be the port that HHVM uses for FastCGI by default. Switching, hopefully that fixes it. |
9000 is used as default by php-fpm/HHVM for FastCGI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use mitmproxy to test our proxy support. It's nice and self contained, plus it's scriptable. Requires Python, but I can deal with that (and Travis has it built-in).
Supersedes the remaining issues from #70 and #72.