Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: start testing against PHP 8.1 #498

Closed
jrfnl opened this issue Jun 18, 2021 · 2 comments · Fixed by #501
Closed

GH Actions: start testing against PHP 8.1 #498

jrfnl opened this issue Jun 18, 2021 · 2 comments · Fixed by #501
Labels
Type: testing/chores/QA
Milestone
2.0.0

Comments

@jrfnl
Copy link
Member

jrfnl commented Jun 18, 2021

Once PR #446 has been merged, it should be possible to add an experimental test run against PHP 8.1 to the test workflow.

This would allow us to ensure the library is compatible with PHP 8.1 ahead of time (for a change).
@jrfnl jrfnl added this to the 2.0.0 milestone Jun 18, 2021
@jrfnl
Copy link
Member Author

jrfnl commented Jun 18, 2021

An initial test run against PHP 8.1.0-alpha1 yielded 16 tests which were erroring out.

I've prepared fixes for all of these and will pull these after PR #446 has been merged.

@jrfnl jrfnl mentioned this issue Jun 21, 2021
Merged
@jrfnl
Copy link
Member Author

jrfnl commented Jun 21, 2021

Fixes pulled as PR #499 and #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: testing/chores/QA
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

GH Actions: run tests against PHP 8.1 WordPress/Requests
1 participant
@jrfnl