Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a release checklist #483

Merged
merged 2 commits into from
Jun 4, 2021
Merged

Add a release checklist #483

merged 2 commits into from
Jun 4, 2021

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Apr 27, 2021

... to document the release process and as a reminder for the future.

... to document the release process and as a reminder for the future.
@ozh
Copy link
Collaborator

ozh commented Apr 27, 2021

Does this file then get automatically displayed somewhere as a prefilled template ?

@jrfnl
Copy link
Member Author

jrfnl commented Apr 27, 2021

Does this file then get automatically displayed somewhere as a prefilled template ?

No, it does not. Unless it has changed without me noticing, AFAIK you can have multiple issue templates, but only one (1) PR template.
With that in mind, it's not useful to set it up as a PR template as it would just confuse people, but having it available in the .github directory still makes it easy to access it for maintainers and copy/paste the content to a release PR.

And independently of the template part of it, it is also a way to just document the steps for doing a release.

@schlessera
Copy link
Member

For WP-CLI, I've added the release check list as an issue template which can be generated (see the last two entries): https://github.com/wp-cli/wp-cli/issues/new/choose

@jrfnl
Copy link
Member Author

jrfnl commented Apr 28, 2021

@schlessera Will have a look and update over the weekend.

@ozh
Copy link
Collaborator

ozh commented Apr 28, 2021

You guys have seen this : https://probot.github.io/apps/release-drafter/ ?

@jrfnl
Copy link
Member Author

jrfnl commented Apr 28, 2021

@ozh My experience with any type of changelog generators is absolutely lousy. They create technical changelogs based on PR titles, which in most cases are completely useless for end-users.

Case in point from this week: https://github.com/gitextensions/gitextensions/blob/release/3.5/GitUI/Resources/ChangeLog.md

That release contained at least two breaking changes (gitextensions#9112 and gitextensions#9113). Aside from the fact that those shouldn't have been allowed to go into a minor, they also weren't mentioned in the changelog and finding the PR which caused them meant having to go through 100+ PRs to see if I could figure it out. I found the cause of one, but not the other.

Yes, it's a pain in the neck having to write up a changelog, but the pain in the neck for end-users being confronted by an absolutely useless PR list is much larger.

@jrfnl
Copy link
Member Author

jrfnl commented May 11, 2021

For WP-CLI, I've added the release check list as an issue template which can be generated (see the last two entries):

@schlessera I've had a look at this, but that would make it an issue template, while it is (was) intended as a PR template for the develop to master merge PR.

@jrfnl jrfnl force-pushed the feature/add-release-checklist branch from aef4d00 to 3edfcab Compare May 11, 2021 20:29
@ozh
Copy link
Collaborator

ozh commented May 11, 2021

FWIW, here's how I do it for YOURLS (infrequent releases so I was always forgetting what's to be done) : I have a draft release that I use as a template and copy/paste everytime then fill, with inline HTML comment helper. Impossible to miss since it's the first thing I see on the relase page when I want to tag a new one :)

Release page:

image

Source :

image

@schlessera schlessera modified the milestones: 2.0.0, 1.8.x Next Jun 4, 2021
@schlessera schlessera merged commit 6b57026 into master Jun 4, 2021
@schlessera schlessera deleted the feature/add-release-checklist branch June 4, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants