QA: use strict comparisons #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strict type comparisons should be used as a rule, with loose type comparisons being the exception. This is especially important when comparing variables which are expected to be strings, as when one of the two operands - for whatever reason - is not a string, the other operand will be juggled to the type of the first operand which can lead to unexpected results and hard to debug bugs. For array functions which do loose type comparisons, setting the third `$strict` parameter to `false` can be seen as a clear indication that this is a conscious, well thought out decision by the developer. In all other cases, `$strict` `true` should be used. Refs: * http://phpcheatsheets.com/compare/equal/ * http://php.net/manual/en/function.in-array.php
schlessera
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strict type comparisons should be used as a rule, with loose type comparisons being the exception.
This is especially important when comparing variables which are expected to be strings, as when one of the two operands - for whatever reason - is not a string, the other operand will be juggled to the type of the first operand which can lead to unexpected results and hard to debug bugs.
For array functions which do loose type comparisons, setting the third
$strictparameter tofalsecan be seen as a clear indication that this is a conscious, well thought out decision by the developer.In all other cases,
$stricttrueshould be used.Refs: