QA: lint PHP files in this repo #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds linting of the PHP files against every PHP version to the Travis build. The `vendor` directory is excluded by default. For PHP 5.2, the `tests/phpunit6-compat.php` file is excluded as it uses namespaces. For PHP < 5.4, the `examples/cookie_jar.php` file is excluded as it uses short arrays.
ntwb
approved these changes
Oct 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds linting of the PHP files in the repo against every supported PHP version to the Travis build.
The
vendordirectory is excluded by default.For PHP 5.2, the
tests/phpunit6-compat.phpfile is excluded as it uses namespaces and is only loaded on PHP 7+ anyway.For PHP < 5.4, the
examples/cookie_jar.phpfile is excluded as it uses short arrays.