-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests by updating domain and PHPUnit versions #351
Conversation
Composer is locked to PHP 5.6, so it will install incompatible versions
feelingrestful.com was decommissioned.
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=========================================
Coverage 92.11% 92.11%
Complexity 760 760
=========================================
Files 21 21
Lines 1762 1762
=========================================
Hits 1623 1623
Misses 139 139 Continue to review full report at Codecov.
|
This should pass now, as all tests are passing except Once that's done, @jrfnl's #346 should fix the failures on "nightly" (we're actually missing 7.3 as well; this will likely fix that too). |
Tests are now passing; I had to restart a couple due to the usual transient failures from external servers. |
Thanks @ntwb! |
feelingrestful.com was decommissioned.
This should 🤞 fix the tests and allow other PRs to be merged.