Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests by updating domain and PHPUnit versions #351

Merged
merged 11 commits into from
Sep 15, 2019

Conversation

rmccue
Copy link
Collaborator

@rmccue rmccue commented Sep 15, 2019

feelingrestful.com was decommissioned.

This should 🤞 fix the tests and allow other PRs to be merged.

@codecov-io
Copy link

codecov-io commented Sep 15, 2019

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #351   +/-   ##
=========================================
  Coverage     92.11%   92.11%           
  Complexity      760      760           
=========================================
  Files            21       21           
  Lines          1762     1762           
=========================================
  Hits           1623     1623           
  Misses          139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4055bc4...a8d6514. Read the comment docs.

@rmccue
Copy link
Collaborator Author

rmccue commented Sep 15, 2019

This should pass now, as all tests are passing except nightly (although it was incorrectly ignored previously). I've incorporated @datagutten's changes from #345 to fix the PHPUnit classes (thanks!).

Once that's done, @jrfnl's #346 should fix the failures on "nightly" (we're actually missing 7.3 as well; this will likely fix that too).

@rmccue rmccue changed the title Update domain name used in tests Fix unit tests by updating domain and PHPUnit versions Sep 15, 2019
@rmccue
Copy link
Collaborator Author

rmccue commented Sep 15, 2019

Tests are now passing; I had to restart a couple due to the usual transient failures from external servers.

@rmccue rmccue mentioned this pull request Sep 15, 2019
@rmccue rmccue merged commit bf35eb2 into master Sep 15, 2019
@rmccue rmccue deleted the fix-failing-tests branch September 15, 2019 22:56
@rmccue
Copy link
Collaborator Author

rmccue commented Sep 15, 2019

Thanks @ntwb!

@jrfnl jrfnl added this to the 1.7.1 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants