-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #345
Fix unit tests #345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #345 +/- ##
=========================================
Coverage 92.11% 92.11%
Complexity 760 760
=========================================
Files 21 21
Lines 1762 1762
=========================================
Hits 1623 1623
Misses 139 139 Continue to review full report at Codecov.
|
Composer is locked to PHP 5.6, so it will install incompatible versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to let Composer sort out the PHPUnit version on every build ?
That would make the Travis script much simpler and more stable.
Thanks so much for this pull request and apologies for the delay. I've rolled these tests into #351 to also update the domain name; will aim to merge that. |
The tests currently use an empty string or the default value for checking exception message which means empty message. The message is not empty and causes the tests to fail. I changed this to null so the message is not checked and those tests pass.