Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests #345

Closed
wants to merge 7 commits into from
Closed

Fix unit tests #345

wants to merge 7 commits into from

Conversation

datagutten
Copy link
Contributor

The tests currently use an empty string or the default value for checking exception message which means empty message. The message is not empty and causes the tests to fail. I changed this to null so the message is not checked and those tests pass.

@codecov-io
Copy link

codecov-io commented Jun 29, 2019

Codecov Report

Merging #345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #345   +/-   ##
=========================================
  Coverage     92.11%   92.11%           
  Complexity      760      760           
=========================================
  Files            21       21           
  Lines          1762     1762           
=========================================
  Hits           1623     1623           
  Misses          139      139

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4055bc4...3a6a2e2. Read the comment docs.

@datagutten datagutten closed this Jun 29, 2019
@datagutten datagutten reopened this Jun 29, 2019
@datagutten datagutten changed the title Fix checking of exception messages Fix unit tests Jun 29, 2019
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make more sense to let Composer sort out the PHPUnit version on every build ?
That would make the Travis script much simpler and more stable.

@rmccue
Copy link
Collaborator

rmccue commented Sep 15, 2019

Thanks so much for this pull request and apologies for the delay. I've rolled these tests into #351 to also update the domain name; will aim to merge that.

@rmccue rmccue closed this Sep 15, 2019
@jrfnl jrfnl added this to the 1.7.1 milestone Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants