Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docblock typo #296

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Fix docblock typo #296

merged 1 commit into from
Sep 26, 2019

Conversation

ozh
Copy link
Collaborator

@ozh ozh commented Oct 20, 2017

No description provided.

@ozh ozh self-assigned this Oct 20, 2017
@ozh
Copy link
Collaborator Author

ozh commented Oct 20, 2017

(I suggest adding [skip ci] to the merge commit because currently unit tests fail because of obsolete phpunit config)

Copy link
Collaborator

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@rmccue
Copy link
Collaborator

rmccue commented Dec 13, 2017

(P.S. can you merge master into this branch? Should fix up the tests.)

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-iterating what @rmccue said: if you could merge in master (or rebase), the builds should pass and this can be merged.

@codecov-io
Copy link

codecov-io commented Sep 26, 2019

Codecov Report

Merging #296 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #296      +/-   ##
============================================
+ Coverage     92.11%   92.16%   +0.05%     
  Complexity      760      760              
============================================
  Files            21       21              
  Lines          1762     1762              
============================================
+ Hits           1623     1624       +1     
+ Misses          139      138       -1
Impacted Files Coverage Δ Complexity Δ
library/Requests.php 75.59% <ø> (ø) 118 <0> (ø) ⬇️
library/Requests/Transport/fsockopen.php 94.76% <0%> (+0.58%) 68% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3470169...3510176. Read the comment docs.

@jrfnl jrfnl merged commit a009398 into master Sep 26, 2019
@jrfnl jrfnl deleted the misctypo branch September 26, 2019 16:04
@jrfnl jrfnl added this to the 1.7.1 milestone Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants