Add Content-* headers for empty POST requests #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Sep 25, 2019
There was a problem hiding this comment.
@dd32 Thank you for this PR and sorry for the long wait.
The change make sense to me.
Looks like #318 also addresses this. Would it be beneficial to add the unit tests from #318 into this PR ? or combine them in some way ?
Also, the assertEquals() should probably be changed to an assertSame() ?
Other than that, would you mind rebasing the PR so it becomes mergable ?
If you don't want to or don't have the time, please let me know.
|
I'm unable to rebase this as I no longer have the original repository it was made in. It looks like a new PR combining this & #318 would make sense (I don't have the bandwidth for this right now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sends the
Content-LengthandContent-Typeheaders even for empty POST requests.The test passes regardless, as it seems that the Heroku test app adds the
Content-Lengthheaders on incoming requests regardless of if it's sent. Testing againsthttp://httpbin.org/postshows that the header isn't/is sent though.Fixes #248