-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cURL: Support custom HTTP methods #227
Conversation
Current coverage is 92.22% (diff: 100%)@@ master #227 diff @@
==========================================
Files 21 21
Lines 1761 1762 +1
Methods 156 156
Messages 0 0
Branches 0 0
==========================================
+ Hits 1624 1625 +1
Misses 137 137
Partials 0 0
|
https://github.com/RequestsPHP/test-server is the source for the test server. :) |
Used for WordPress/Requests#227.
9278fea
to
593972e
Compare
@rmccue No idea why it returns a 501 error. :( |
05bca1e
to
24f033f
Compare
Instead of adding a new case we can also combine the default case with PATCH, PUT, DELETE and OPTIONS. See https://core.trac.wordpress.org/attachment/ticket/37503/37503.2.patch. @rmccue Let me know if this is a better approach, happy to refresh the PR. (It would also fix the coverage thing. :)) |
Coverage can be pretty safely ignored for <0.1%; I tried this PR locally and it worked, but not on Travis, so need to get to the bottom of that. Haven't had time yet, alas. I'd prefer the switch be explicit in what it supports, but |
Tests passing, wunderbar! |
See https://core.trac.wordpress.org/ticket/37503 for background.
The test doesn't work (yet) because there is no /purge endpoint.