Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cURL's version_number and cleanup the version_compare() stuff #104

Merged
merged 1 commit into from
Mar 23, 2014
Merged

Use cURL's version_number and cleanup the version_compare() stuff #104

merged 1 commit into from
Mar 23, 2014

Conversation

mishan
Copy link
Contributor

@mishan mishan commented Mar 11, 2014

No description provided.

@mishan
Copy link
Contributor Author

mishan commented Mar 11, 2014

Hm not sure why the build failed here.

@mishan
Copy link
Contributor Author

mishan commented Mar 11, 2014

Looks like build only failed under hhvm ; not sure how to reproduce this locally

@ozh
Copy link
Collaborator

ozh commented Mar 11, 2014

Don't mind this. I've been pestering @rmccue about moving the .travis.yml hhvm bit into its own branch so that doesn't affect everything else but no luck :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e186156 on mishan:improve-curl-version-compare into 5c54aaa on rmccue:master.

@mishan
Copy link
Contributor Author

mishan commented Mar 19, 2014

@rmccue

@rmccue
Copy link
Collaborator

rmccue commented Mar 23, 2014

Sorry for missing this one. Thanks for the patch!

rmccue added a commit that referenced this pull request Mar 23, 2014
@rmccue
Merge pull request #104 from mishan/improve-curl-version-compare
83508b9 
Use cURL's version_number
@rmccue rmccue merged commit 83508b9 into WordPress:master Mar 23, 2014
@rmccue rmccue added this to the 1.7 milestone Mar 23, 2014
@rmccue rmccue added Core and removed Core labels Mar 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Transports
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mishan @ozh @coveralls @rmccue