Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2871 follow-up style updates #2876

Merged
merged 18 commits into from
Sep 9, 2024
Merged

2871 follow-up style updates #2876

merged 18 commits into from
Sep 9, 2024

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Sep 5, 2024

Resolves #2871

Replace eye icon with bullet point

Screenshot 2024-09-06 at 07 22 03

Single quiz

4.mov

Separator on the standalone lesson page

image

Only shows course progress counter when user is not enrolled

image

@renintw renintw changed the base branch from trunk to 2638-Single-Lesson-Polish-the-design September 5, 2024 22:39
@renintw renintw changed the title 2871 follow up style updates 2871 follow-up style updates Sep 6, 2024
Base automatically changed from 2638-Single-Lesson-Polish-the-design to trunk September 6, 2024 16:18
@renintw renintw marked this pull request as ready for review September 8, 2024 19:23
@renintw renintw self-assigned this Sep 8, 2024
@renintw renintw added the [Component] Learn Theme Website development issues related to the Learn theme. label Sep 8, 2024
@renintw renintw added this to the Learning Pathways Post-launch milestone Sep 8, 2024
@adamwoodnz
Copy link
Contributor

Minor, but the complete quiz button focus style doesn't quite match the others

Screenshot 2024-09-09 at 2 26 12 PM

Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, just one minor thing I noticed

@renintw
Copy link
Contributor Author

renintw commented Sep 9, 2024

Minor, but the complete quiz button focus style doesn't quite match the others

e2d085a

Screenshot 2024-09-10 at 03 11 48

@renintw renintw merged commit 6616fa5 into trunk Sep 9, 2024
1 check passed
@renintw renintw deleted the 2871-follow-up-style-updates branch September 9, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Learn Theme Website development issues related to the Learn theme.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Follow-up style updates
2 participants