Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate component for responsive version of graph #7

Open
WikKam opened this issue Jan 30, 2022 · 2 comments
Open

Create separate component for responsive version of graph #7

WikKam opened this issue Jan 30, 2022 · 2 comments

Comments

@WikKam
Copy link
Collaborator

WikKam commented Jan 30, 2022

Right now, the default version of the graph is the responsive one, which uses ResizeObserver and redraws graph on each event. I think that this can hit performance and we should make it possible for the user to pick which version he wants to use

@ZachHaber
Copy link
Collaborator

I can take care of that. I just need to figure out a good way to make the internal example files runnable with the current code so we can work on it without issue, and so that the builds for the site are based on the "live" version of the code rather than a specific version of the package.

@WikKam
Copy link
Collaborator Author

WikKam commented Feb 5, 2022

@ZachHaber Me and @Wokstym are using our Engineering's thesis repo (That's the reason why we decided to publish this xD), and linking the lib via npm link command. We should add storybook to this project tho, it will allow for such testing. I will create the issue also for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants