Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchor issues #400

Open
vertigo220 opened this issue Dec 7, 2024 · 2 comments
Open

Anchor issues #400

vertigo220 opened this issue Dec 7, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request Feature-Anchors UsersCount-2

Comments

@vertigo220
Copy link

vertigo220 commented Dec 7, 2024

Despite being set to stay away from images, anchors still show over my video player (PotPlayer). This results in them being obtrusive and less visible when the video is paused and being hidden behind it when playing, due to it being set to be on top when playing. (Edit: Just found that the emphasized anchors actually manage to show over PotPlayer even when playing, which is a major problem and makes them entirely unusable.) Either they should be made to avoid being on top of video players or there should be a way to specify which programs' windows they avoid.

It should also allow whitelisting/blacklisting apps to show anchors, so it can be set to only show certain ones or to show all but certain ones.

I'm probably just getting various features confused due to being new to this, but despite enabling the various settings for interacting with the preview windows, when I hover over an anchor and try to move the mouse to the preview to interact with it, it goes away. I'm also noticing that often when this happens, the anchor jumps (so far always to the left by ~1-2"), which is annoying.

When activating a window via its anchor, there's a couple second delay between the window showing and it becoming active. During this time, things don't work as expected, which causes a bit of frustration. For example, if I activate a window then hit Alt+Tab, I expect to be back in the window I was in before clicking the anchor. Instead, the window that showed but didn't activate when clicking the anchor just flashes and becomes active instead. Possibly worse still is that this isn't always the case, but instead only happens sometimes, making for an inconsistent experience.

Also, it takes ~2-3 seconds for anchors to update after switching windows.

Despite having it set to emphasize by size for the first 3 anchors, it seems to only do it for 2. For example, I switch from window 1 to window 2, back to window 1 (at which point window 2's anchor is enlarged), then to window 3, and window 2's anchor is now small.

Finally, the window title text sometimes shows over top of another window's anchor. Considering this app is displaying both, it really should be able to prevent this from ever happening.

@gileli121 gileli121 added Feature-Anchors bug Something isn't working enhancement New feature or request labels Dec 8, 2024
@gileli121
Copy link
Member

gileli121 commented Dec 8, 2024

@vertigo220
Thanks for your feedback.

Despite being set to stay away from images, anchors still show over my video player (PotPlayer). This results in them being

Yes, it’s a known issue. My initial plan to fix it was to detect when an app enters fullscreen mode and, in such cases, automatically disable all anchors.

However, after your input (considering the "stay away from images" feature as a potential solution), I’m now thinking of a different approach. If the algorithm is unable to find an empty space without text or an image, it could simply hide the anchor altogether.

This is an idea I hadn’t considered before, but it might work effectively. Currently, when the algorithm cannot find a suitable space, it does nothing. Instead, this new behavior would hide the anchor in such situations.

This approach would likely address scenarios involving video players, as fullscreen video players usually display an image across the entire screen. With this adjustment, the anchors would be hidden automatically in most cases.

It should also allow whitelisting/blacklisting apps to show anchors, so it can be set to only show certain ones or to show all but certain ones.

This is a feature request. Could you please open it as a separate issue?
I’d prefer to keep this one focused solely on bugs or problems with the feature.

I'm probably just getting various features confused due to being new to this, but despite enabling the various settings for interacting with the preview windows, when I hover over an anchor and try to move the mouse to the preview to interact with it, it goes away. I'm also noticing that often when this happens, the anchor jumps (so far always to the left by ~1-2"), which is annoying.

I am aware of this issue.
I plan to address it while working on [this comment in issue #369](#369 (comment)).
Once it becomes event-based, the anchors will respond more quickly as well.

Despite having it set to emphasize by size for the first 3 anchors, it seems to only do it for 2. For example, I switch from window 1 to window 2, back to window 1 (at which point window 2's anchor is enlarged), then to window 3, and window 2's anchor is now small.

I tried to reproduce the issue but couldn’t succeed.
Could you please provide a recording of it or explain it in more detail?

Finally, the window title text sometimes shows over top of another window's anchor. Considering this app is displaying both, it really should be able to prevent this from ever happening.

When this happens, is the anchor title incorrectly displayed on the left side (even though it should be on the right because there’s space available)?

If so, I’m aware of this issue, and it’s the first time someone has reported it. The algorithm calculates the position assuming the anchor title will appear on the right. However, for some reason, the UI displays it on the left instead. As a result, the algorithm positions the anchor in a way that causes its text to unintentionally cover something.

@vertigo220
Copy link
Author

Keep in mind the issue with the video player was referring to playing video in a window, not fullscreen. As mentioned, in fullscreen it hides all but emphasized anchors. But when playing in a window, anchors are shown over it, which is undesirable. This is why it might be better to allow specifying to never show them over windows belonging to certain apps/exes. I'll open a separate feature request for that, but while it can be considered as a FR, it's really about dealing with this issue. Also, this means they should actually be moved elsewhere, so they are still visible, as opposed to simply being hidden behind such windows, preventing them from being used.

I tried to reproduce the issue but couldn’t succeed.
Could you please provide a recording of it or explain it in more detail?

I'll try to remember to do this later, but for now I have them disabled as they get in the way too much due to the other issues.

When this happens, is the anchor title incorrectly displayed on the left side (even though it should be on the right because there’s space available)?

I believe it was. As with the previous issue, I'll have to try and remember to test it more when I'm able to play with anchors more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Feature-Anchors UsersCount-2
Projects
None yet
Development

No branches or pull requests

2 participants