Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar activation: Keep Hover on Minimize but Disable 'sticky' Arrow #384

Open
AlteredCabr0n opened this issue Oct 8, 2024 · 16 comments
Open
Labels
bug Something isn't working investigating

Comments

@AlteredCabr0n
Copy link

I like the minimize button integration but don't need the arrow.
image
feature to allow hovering over the minimize to activate Toolbar but without needing the arrow there.

@gileli121
Copy link
Member

@AlteredCabr0n
The first option determines whether the toolbar is displayed with or without the arrow (the one that is green by default, not the one inside the toolbar below the SET TOP button).

This needs to be enabled; otherwise, you can only use it with hotkeys.

Did you try it? I think it already works as you want if you turn on the second option (the first option must be turned on to enable the toolbar).

If the second option is enabled (in addition to the first), the arrow will be disabled, and only the toolbar will show up when the mouse hovers over the minimize button. However, if it fails to identify the minimize button (due to reasons such as no minimize button being available or any other issue), it will fall back to the first behavior, showing the arrow (hovering over it will display the toolbar).

I assumed that when you said "arrow," you were referring to the one above the toolbar, not the one inside below the SET TOP button. If you mean the arrow below the SET TOP button, let me know. In that case, I wonder why you care about it.

@AlteredCabr0n
Copy link
Author

If the second option is enabled (in addition to the first), the arrow will be disabled, and only the toolbar will show up when the mouse hovers over the minimize button. However, if it fails to identify the minimize button (due to reasons such as no minimize button being available or any other issue), it will fall back to the first behavior, showing the arrow (hovering over it will display the toolbar).

That doesn't seem to be what happens.

WindowTopARROWTest.1_2024-10-10_16.40.17.mp4

@gileli121
Copy link
Member

@AlteredCabr0n
This isn't the expected behavior. What OS are you using? It doesn’t seem like Windows 11. Is it Windows 10? According to my tests, it should work on Windows 10. Or maybe it's Windows 8? Do you use any additional apps like Stardock Groupy or something else that adds functionality to Windows?

@gileli121 gileli121 added bug Something isn't working investigating labels Oct 12, 2024
@AlteredCabr0n
Copy link
Author

@AlteredCabr0n This isn't the expected behavior. What OS are you using? It doesn’t seem like Windows 11. Is it Windows 10? According to my tests, it should work on Windows 10. Or maybe it's Windows 8? Do you use any additional apps like Stardock Groupy or something else that adds functionality to Windows?

I'm using Windows 10 22H2. I have other apps installed that affect windows (ex. Actual Window Manager), but these have been disabled.

@gileli121
Copy link
Member

@AlteredCabr0n
Thanks for the information. I still can't reproduce the issue, but I'll keep trying to figure it out.
It seems like you do have apps affecting Windows (like Actual Window Manager).
From your comment, it sounds like you have more than one such app.
Could you please mention all other installed apps that affect Windows?

@AlteredCabr0n
Copy link
Author

Could you please mention all other installed apps that affect Windows?

I've just been able to replicate the issue on a different machine and a clean install VM. No other apps installed.

WindowTopARROWTest.2_2024-10-19_00.00.08.mp4

@gileli121
Copy link
Member

Interesting.
I will check it now on Windows 10 VM on file explorer window.
Maybe it broke after some update on windows 10

@gileli121
Copy link
Member

@AlteredCabr0n
After reviewing your video again, it seems this isn't a bug but expected behavior. This happens because you disabled the entire toolbar.

I understand the toggle’s name might be confusing. However, the "Enable Toolbar" toggle controls both the toolbar and the arrow. I tried to clarify that here:
image
As mentioned, you can only enable or disable window features through hotkeys, so I hoped this would make it clear to users.

Additionally, when the toolbar is disabled, all other related options are also deactivated, as they are tied to the toolbar UI (the arrow and the toolbar itself). As shown in your video, this behavior is working as intended.

So I still need to figure out how to reproduce the bug, as this video doesn't seem to demonstrate the issue.

@gileli121
Copy link
Member

Additionally, the feature worked as expected on Windows 10—specifically, the option to display it when hovering over the minimize button.

@vertigo220
Copy link

I may be misunderstanding, but I think the issue here is they want the toolbar to show when hovering over the minimize button but do not want the green arrow to show. In other words, they only want one way to access the toolbar, via the minimize button. But it seems the design is that you either can have the green arrow, both the green arrow and the minimize button hover, or neither, but not the minimize button hover without the green arrow. And actually, I myself was confused by this initially, as I thought it was an either/or, and the green arrow did seem to stop showing when I enabled the minimize button option, but since found that not to be the case and I think it just doesn't show in some apps, like Brave (probably because there's no normal title bar, and the tabs are where it would be).

But I would also like the ability to have the toolbar when hovering over the minimize button while not having the green arrow, though the minimize hover doesn't always work (e.g. PotPlayer), so getting rid of the arrows might result in not always being able to access it. Perhaps there could be an additional option to show them when hovering over the title bar and holding ctrl and/or shift or something along those lines.

@gileli121
Copy link
Member

@vertigo220
I never thought about it that way.
Currently, if the algorithm fails to find the minimize button, it falls back to displaying the arrow, which always works.

According to your suggestion, in such cases, there would be no fallback. That is, the arrow wouldn't be displayed at all.

When I designed this, I never imagined a user would prefer something different (not even showing the arrow).

But on second thought, this could be a legitimate option for a user. Perhaps a user might prefer to use hotkeys as a second option instead of displaying the arrow.

Is that what you'd want? Would you like such an option (not falling back to the arrow)?

@vertigo220
Copy link

Currently, if the algorithm fails to find the minimize button, it falls back to displaying the arrow, which always works.

Ah, that would explain things. It doesn't always show, which is why at first I thought enabling the minimize button toolbar disabled that, but then I saw it occasionally, and now that you mention that, I think that's typically been when the minimize button toolbar doesn't work.

I don't think I really care one way or another. I initially thought I wouldn't want the arrow, but it's really unobtrusive and usually doesn't show since the minimize button works in most apps. So I'm fine the way it is, though I would suggest making this behavior more clear in the setup/options. As for @AlteredCabr0n's preference, they'll have to chime in.

@gileli121
Copy link
Member

@vertigo220

Okay, thanks for the feedback.
I’ll work on improving it and making it clearer. If you have specific ideas on what to write and how to present it, that would be very helpful.

Thank you!

@vertigo220
Copy link

I'd suggest just putting something along the lines of what you said here in the settings. For example:

Integrate with the minimize button

Show the toolbar by hovering over the minimize button. This will disable the title bar arrow for windows in which the minimize button is detected; in those it is not, the arrow will show instead, unless it is disabled completely.

I've italicized the text that's different from the current text. You'll notice I added the word "over" to the first sentence, which is otherwise the current description. The second sentence describes the behavior of not showing the arrow, and the underlined part would be if you were to add an additional option to never show the arrow. Note it doesn't refer to it as the "green" arrow since the user may have changed the color, which could cause confusion (you could get really fancy and have it determine the current color and dynamically change the text to refer to it by color, but that's unnecessary).

I'd also suggest moving the arrow settings from the bottom of the page to either right above or right below the hover time setting, as currently that page goes from toolbar settings/config, to hover time for activating it, to an alternate way to activate it (minimize button), back to configuring the primary activation method (the arrow). It just seems out of order to me, and especially if you refer to the arrow in the description for the minimize button setting, it would definitely be out of order, as you'd be referring to something before introducing it via its setting. It makes much more sense to me to have the main toolbar enable/disable setting, followed by configuring of the toolbar, then the arrow config followed by the minimize button setting, with the hover time either before or after them.

You could also change it so instead of having "Integrate with the minimize button" as a heading, it could be "Activation configuration" with either a single toggle to select between the arrow and the minimize button (with the current design of having it do one or the other, and with similar text as above when switched to the minimize button to indicate the arrow will still be shown in some cases) or two or three toggles, one to enable/disable the arrow and one to enable/disable the minimize button hover, with a possible third that's active when the minimize button hover toggle is enabled to toggle whether the arrow will show when the minimize hover doesn't work. Then they could all be grouped together nicely, the hover time could be placed under them, and the animation could change depending on the settings to show how it would work. You could even then get rid of the "Enable Toolbar" toggle and put these toggles there under that heading, since flipping both primary ones (arrow and minimize hover) to off would disable the toolbar, and flipping either one on would enable it.

So anywhere from a small text change to completely rearranging things, just depends how much you want to put into it and what you prefer. Just throwing out ideas for you to contemplate.

Also, I just want to mention the irony, which I just discovered looking at this, that WindowTop doesn't recognize its own minimize button. Doesn't really matter, but thought that was interesting. :)

@gileli121
Copy link
Member

gileli121 commented Dec 17, 2024

Thank you very much for your suggestions and ideas!
I will take them into account when improving the user interface. I'll probably start with minor changes, such as slightly adjusting the explanations based on your suggestions.

Also, I just want to mention the irony, which I just discovered looking at this, that WindowTop doesn't recognize its own minimize button. Doesn't really matter, but thought that was interesting. :)

That's very interesting. It’s surprised that WindowTop own minimize button is not detected.
WindowTop doesn’t do anything special with its windows regarding the minimize button, so it’s expected that this button should be detected.
I will definitely look into this and aim to fix it. It’s very likely that many other programs work like WindowTop in how they create windows, as this is something standard.

Thank you for bringing this to my attention!

@AlteredCabr0n
Copy link
Author

I may be misunderstanding, but I think the issue here is they want the toolbar to show when hovering over the minimize button but do not want the green arrow to show. In other words, they only want one way to access the toolbar, via the minimize button. But it seems the design is that you either can have the green arrow, both the green arrow and the minimize button hover, or neither, but not the minimize button hover without the green arrow. And actually, I myself was confused by this initially, as I thought it was an either/or, and the green arrow did seem to stop showing when I enabled the minimize button option, but since found that not to be the case and I think it just doesn't show in some apps, like Brave (probably because there's no normal title bar, and the tabs are where it would be).

But I would also like the ability to have the toolbar when hovering over the minimize button while not having the green arrow, though the minimize hover doesn't always work (e.g. PotPlayer), so getting rid of the arrows might result in not always being able to access it. Perhaps there could be an additional option to show them when hovering over the title bar and holding ctrl and/or shift or something along those lines.

Yes this is exactly what I mean thanks. You articulated it better than me. Hopefully we might see this in a future update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigating
Projects
None yet
Development

No branches or pull requests

3 participants