Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate hue 180 degree in dark mode #362

Closed
luo-chuan opened this issue Jun 8, 2024 · 5 comments
Closed

Rotate hue 180 degree in dark mode #362

luo-chuan opened this issue Jun 8, 2024 · 5 comments
Labels
bug Something isn't working done enhancement New feature or request Feature-Dark-Mode fixed

Comments

@luo-chuan
Copy link

Rotating hue 180 degree in dark mode will keep red in red, green in green, blue in blue.

@gileli121
Copy link
Member

gileli121 commented Jun 8, 2024

This sounds like extremely great suggestion and should not be hard addition!
When I finish with #332 this is probably something that I will implement first.

@gileli121 gileli121 added enhancement New feature or request Feature-Dark-Mode in-progress bug Something isn't working done labels Jun 8, 2024
@gileli121
Copy link
Member

@luo-chuan

It implemented

Before After
image image

Please try this version and let me know how it looks
https://github.com/WindowTop/WindowTop-App/releases/tag/v5.22.10

I am wondering if this should be an option in settings, or it is just how it should work anyway (and it was a bug)
I am concerned that this proposed change might impact the readability of some texts.
Please give me feedback if after applying it, you can still easily read the text as before.

@luo-chuan
Copy link
Author

With v5.22.10. Effects are as follows.
Before:
图片
After:
图片
That is great.

@gileli121
Copy link
Member

@luo-chuan
looks great
But I think that it should be option in settings
Because in some cases the text is a little less readable

@gileli121
Copy link
Member

@luo-chuan
Please check this version
https://github.com/WindowTop/WindowTop-App/releases/tag/v5.23.0

The difference now is that it added as an option that you can change from toolbar and settings

dark mode fix colors

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working done enhancement New feature or request Feature-Dark-Mode fixed
Projects
None yet
Development

No branches or pull requests

2 participants