-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowTop v5.7.8 Setup.exe is zipped #186
Comments
Aha, weeeeell, that window will go away once Windows Defender SmartScreen have scanned the software for potential harmful code, and since we submit it to winget it should be approved by every AV vendor pretty quickly But if that is what you want to do you'll do that :) |
This is what I found. I tested it on another computer and saw this behavior.. |
If you decide to do the zipped method we won't be able to submit new versions because we're waiting for microsoft/winget-cli#859 |
Great, thanks 😁 |
Good question. But I think that in this case it was too much and I was supposed to call it v5.8 |
@OfficialEsco |
The normal way of doing GitHub releases is to make a new release/tag for each version, aka And in some cases its easier to see the patch notes on the releases page, however you've actually managed to make a pretty cool patch note so i'm kinda conflicted about what to say 😁 I'm not here to make you change your mind about anything, its just about convenience for Package Managers, which i guess makes it a bit harder for you since you've decided to do it this way Feel free to close |
OK, thanks for sharing your thoughts. Btw, the number 5 is not going to change and there is no plan to do it. This number changed from 4.X.X to 5.X.X when the app was rewritten to C#. I think that this was the only valid case. I think that the version should start with 2.X.X and not 5.X.X. It changed from 3.X.X to 4.X.X when only part of it was ported to C# (the UI part). Then it changed from 4.X.X to 5.X.X when it was fully ported C# from AutoIt. Btw, where is the download/installation instructions page for the the winget method? |
in theory here: https://docs.microsoft.com/en-us/windows/package-manager/winget/ Did some testing since you also release to Microsoft Store Tips to how front end webpages does it |
@OfficialEsco |
And maybe I will make v5.7.8 unavailable to make it look more sense |
Hmm, what makes 5.7.8 so special? From my POV it looks like 5.6.X where you have both Optimize, Improved, Implement and Fixes, why can't you do 5.7.9 for the hotfix? edit: |
@OfficialEsco These fixes are major: I used to have a general role: If you have a lot of stuff that starts with "Implemented:" - then I should change the number in the middle and not the last number after the dot. |
I think that I will do as in https://github.com/JanDeDobbeleer/oh-my-posh/releases It is similar to my role but in my role I said that to increase the middle number you need nice amount of features |
IMO any Implementations should get a new version number |
I will do it this way. I also see how it will make my life easier. |
That does not really matter :) It just means you've found A LOT of Improvements |
What is |
In some cases yes But i believe its just a split to increase the version number since his 3* version went up to 3.181.2 |
Looks like when there are BREAKING CHANGES he change the first number right? |
I think so yes, or since you are releasing to Microsoft Store dropping support for a Windows 10 version |
I am considering to remove the "Glass Mode" feature because it is unstable and almost no one use it from what I know. |
I think that no |
Na, not since its unstable |
OK, thanks |
Hey, Winget Package Contributor here, why is the WindowTop v5.7.8 Setup.exe zipped?
The text was updated successfully, but these errors were encountered: