-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move initDriver() to SeleniumBaseTest constructor #182
Comments
It's not correct to add this call to constructor. |
@BlackEnf0rcer we need to remember that a test class might contain more than 1 test method. So I agree that naming of a "get" and the fact that driver is actually created in it is not very clear. But I would like the creation of a driver to be controllable by the user. I.e. we just need to add a single line in documentation saying "to start driver, use "open" method". That's it. The users will then be able to build any logic up to their needs and taste. e.g. add a beforeMethod, or anything. So, what do you say if we just find a clearer name for the method? |
@vefimofff After some reflections, I think it's a good idea to have a control of driver creation on test developer side. But what worries me, that there are two metods: static PageProvider.get that not loading driver and non-static method SeleniumBaseTest.get that loading driver. So I have to worry about driver when i need static method, so I suggest to rename method get to openPage and make it static. |
Now it's not clear that you have to call get() method to init web driver by call WebDriverFactory.initDriver();
The text was updated successfully, but these errors were encountered: