Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the encrypted backup! #1705

Closed
schmitmd opened this issue Jul 17, 2014 · 28 comments
Closed

Bring back the encrypted backup! #1705

schmitmd opened this issue Jul 17, 2014 · 28 comments

Comments

@schmitmd
Copy link

I loved the fact that I could export an encrypted backup of my texts. Version 2.1.0 took this functionality away, please put it back ASAP or make a disclaimer on why it's gone.

@mcginty
Copy link
Contributor

mcginty commented Jul 17, 2014

Hey @schmitmd, it's coming back. The reason we removed it temporarily is because it was giving falsely encouraging messages of successful backups but many people were unable to import. Hoping to get a fixed encrypted export out soon.

@schmitmd
Copy link
Author

Wow, that was quick. Looking forward, I'll keep my eyes peeled.

5 stars on the play store for responding to this almost before I was finished making the issue and providing an open-source solution for keeping private communications private. Thanks!

@patcon
Copy link

patcon commented Jul 20, 2014

Rockin. Thanks! Was going through the prep to root my device, but I'll wait a few days :)

@dolanor
Copy link

dolanor commented Jul 22, 2014

I was pretty disappointed to see disappear too.

Is it sure that that feature didn't work ?
I tried it tonight with the previous version of TextSecure (2.0.8). I backed up the data, then removed the textsecure app, reinstalled it and imported the encrypted backup. Everything is fine.
But there is an issue !
The conversations shows : error decrypting message in place of every message.
You need to let TextSecure work for a few minutes, and then the error decrypting message are replaced by the real message. (I have 9000 messages with mms pictures and stuff, and everything is fine).

So for me, it's more of message to display to user to wait until TextSecure decrypt all the message one after another than a real bug with the backup.

@patcon
Copy link

patcon commented Jul 22, 2014

@dolanor Not a maintainer, but I think the logic was that sporadic failures that weren't yet resolved were worth removing the feature, particularly with something as important as backup. So it may work fine for some, like yourself, while still being responsible to remove :)

@dolanor
Copy link

dolanor commented Jul 23, 2014

I didn't check all the issues about the backup. But I was certain it wasn't working when I saw the error decrypting message, whereas it was good. I just needed patience, and a message would have been a help to wait.

@patcon
Copy link

patcon commented Jul 23, 2014

Ah, good point.

@benmayne
Copy link

Can I assume that without this, the only way to migrate phones is to start from scratch?

@perguth
Copy link

perguth commented Aug 16, 2014

@benmayne: You can still export plaintext.

@hacklschorsch
Copy link

I just lost 6 months of messages and photos because of this. I was not aware that textsecure isn't doing backups automatically anymore. If I had been, I would have used some other tool to backup the complete phone memory or something.

Ref #1631.

@patcon
Copy link

patcon commented Aug 27, 2014

@hacklschorsch as far as I understand, this is not about automated backups. I wasn't aware that this was ever offered tbh. If it did exists and went away, I'd say open a new issue to make sure it gets the discussion it deserves :)

@hacklschorsch
Copy link

Right, @patcon, thanks for opening the new issue. I believe I was under the impression that encrypted backups would be done automatically because there was no button to do it manually. Replacing the button with a disabled one instead of removing it completely might have been easier to understand... well whatever, thanks!

@squisher
Copy link

Any ETA on this? This is pretty horrible, I wanted to switch android versions but don't want to loose my MMS. Now it seems I'm stuck!

@perguth
Copy link

perguth commented Sep 19, 2014

I am stuck too because of all the images and my OS is falling apart :-(

@tinloaf
Copy link
Contributor

tinloaf commented Sep 19, 2014

@pguth @squisher You should be able to migrate using Helium Backup: Unregister from push, make a helium backup, transfer to the new phone, restore the backup, register for push.

@perguth
Copy link

perguth commented Sep 21, 2014

@tinloaf Thanks, that worked quite conveniently!

@ISeeBinary
Copy link

Any news on the release date of this?

@Diapolo
Copy link

Diapolo commented Oct 14, 2014

I also think this is missing currently, but use Titanium Backup, which also does the job ;).

@dolanor
Copy link

dolanor commented Oct 20, 2014

I also used Helium Backup, and it worked well (just a little bit of a pain to use with the adb devices and stuff)

@tjnicholas
Copy link

Would it be simpler/quicker to just replace the feature with a key export/import function?

@akonyer
Copy link

akonyer commented Nov 24, 2014

It's brutal not being able to transfer this to a new device easily.

@smarek
Copy link
Contributor

smarek commented Dec 13, 2014

Hi, any progress on this please?

@A-xis
Copy link

A-xis commented Dec 26, 2014

Nothing ?
Can you PLEASE, add a notice about this disabled functionnality somewhere?

@landry314
Copy link

i dont care about my texts but my keys i would like a clean and secure way to migrate to a new phone when i upgrade. does the export plaintext option export private keys in plaintext? i would be shocked. does it have anything to do with the keys or just the texts? should i just move the files in /data/data manually to export my keys? are they even stored there?

@phipolis
Copy link

I agree with @landry314 that exporting the private keys would be an excellent stopgap until encrypted backups can be restored. Only power users are going to use 3rd-party apps to backup their TS configuration. For everyone else, a new phone means a new key. This really bothers me, it blows the TOFU model out of the water. Users get used to clicking through key change alerts accompanied by "it's fine, I got a new phone" messages. Uh-huh.

IMO it's bad enough that users have to know about and remember to use the export function in settings to keep key continuity. Having no option there and needing to use (and know about) 3rd-party apps is even worse. As @pguth's #1876 suggests, Flock is perfectly positioned to provide seamless device-independent backups of the key material. Backups that don't require the user to remember, nor even to have a concept of key continuity. This to me seems to align best with the OWS imperative of simplicity.
[edit: tired]

@landry314
Copy link

absolutely, i got a new phone today and had to text everyone to end their sessions and start a new one to make new key exchanges... which was unnecessary work.

also, at any time today a man in the middle attack could have occurred and now any key verification i have done in the past is null and void because i have all new keys.

all private/public key encryption apps should have a clean export private keys option for migration or reflashing of phones.

right? :-)

@signalapp signalapp locked and limited conversation to collaborators Feb 28, 2015
@2-4601
Copy link
Contributor

2-4601 commented Dec 24, 2016

In #5931 (comment) moxie wrote:

We do not use GitHub for discussion or Q&A. Please do not open issues here just to ask questions or bump topics. If an issue is locked, it's generally because there has been too much discussion or people have been too verbose.

For this issue, the work to be done is very straightforward:

  1. Make plaintext backup complete. It should export media, groups, preferences, block lists, etc... in addition to just text messages. All in a format compatible with SMS Backup & Restore.

  2. Wrap the now complete plaintext backup in an encrypted stream.

  3. Include the identity key in the encrypted stream.

I wish I had enough time to discuss at length why this is the only approach that will work for us, but sadly I don't have the time to do that for every issue. I also wish I had enough time to do this work, along with all of the other open issues here, but I have to make choices. If this is an issue that's important to you, I think step 1 would make a great PR. Please see the mailing list or the online forums for further discussion, thanks.

@2-4601
Copy link
Contributor

2-4601 commented Mar 31, 2018

24e573e

@2-4601 2-4601 closed this as completed Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests