Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device.identified is an integer #65

Open
perqa opened this issue Nov 17, 2022 · 1 comment
Open

device.identified is an integer #65

perqa opened this issue Nov 17, 2022 · 1 comment

Comments

@perqa
Copy link

perqa commented Nov 17, 2022

It looks like device.identified is an integer, not a boolean, as it says in the ReadMe. Is there any significance to the number?

"device": {
    "type": "gaming",
    "subtype": "console",
    "identified": 4,
    "generic": false,
    "hidden": false,
    "manufacturer": "Sony",
    "model": "PlayStation 4",
    "series": null,
    "carrier": null,
    "identifier": null
  },
@mariotsi
Copy link
Member

mariotsi commented Nov 1, 2023

Hello, you are correct. The integer come from this mapping src/constants/id.js. You can still threat it as a boolean since 0 and undefined means not identified while any other integer means identified.

I will however change the typings and the Readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants