Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cross-repository screenshot mask #10164

Open
cfm opened this issue Oct 11, 2023 · 3 comments
Open

support cross-repository screenshot mask #10164

cfm opened this issue Oct 11, 2023 · 3 comments
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.

Comments

@cfm
Copy link
Contributor

cfm commented Oct 11, 2023

Describe the problem

freedomofpress/securedrop stores its screenshots in freedomofpress/securedrop-docs. We don't want to store them directly in the securedrop repository. Instead, we'd like to be able to set the screenshot mask of securedrop's Weblate component to the corresponding mask within the securedrop-docs repository.

Describe the solution you'd like

We've thought of three options:

  1. Support internal (weblate://) urls in the Component.screenshot_filemask field, so that we can add securedrop-docs as a component (whether or not actually translated) and refer to it that way from the securedrop component.
  2. Support submodules, so that securedrop can pull in securedrop-docs without containing its Git objects directly.
  3. Support Git LFS, so that securedrop can pull in securedrop-docs without containing its file content directly.

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

Our use-case is described in freedomofpress/securedrop#6968.

@nijel
Copy link
Member

nijel commented Oct 11, 2023

AFAIK git-lfs should be supported, at least I saw some reports about that. Not sure if that is the best approach for this.

@nijel
Copy link
Member

nijel commented Oct 12, 2023

I don't think 1 is a viable approach. Introducing fake components just to mirror another repository is not something we want to encourage. So that really leaves 2 and 3. I know some projects on Hosted Weblate are using Git LFS, but probably not for content used by Weblate, so there might be some bits of the support missing.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Oct 12, 2023
@github-actions
Copy link

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

No branches or pull requests

2 participants