Refactor API to work with a single Page entity and update UI accordingly. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/webiny-entity-mysql/__tests__/count.test.js # packages/webiny-entity-mysql/__tests__/find.test.js # packages/webiny-entity-mysql/__tests__/findOne.test.js
# Conflicts: # packages/webiny-entity-mysql/__tests__/save.test.js # packages/webiny-entity-mysql/src/mysqlDriver.js
Pavel910
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working with both Pages and revisions became quite complicate so I refactored the entire logic to work with a single Page entity. When a page is created, it automatically gets a version
1, and itsparentfield is the same as itsid.When a new revision is created - a new Page entity is stored, and it has a
parentvalue of the original page (the actual root page, not the revision used to create the revision). So when you look at the data in the DB, all revisions related to the same page have the same value ofparentfield.To load the page list data we use a custom SQL query, which groups all revisions by the
parentfield and orders the results by eitherpublishedfield odversionfield.Besides the pages list, this PR also contains a lot of bug fixes and minor refactors to make the entire CMS structure better and easier to understand.