Ensure before / after events are executed independently #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These events must be executed outside save process.
This means that once the save starts, immediately execute
beforeSave
,beforeUpdate
,beforeCreate
events, and only then start the actual processing of entity. The same goes for "after" events, execute them once processing has been completely done.This was done simply by renaming current
before
andafter
events to__before
and__after
, making them internal events, and inserting new ones that follow the explained behavior.Motivation:
Eg.
onAfterCreate
developer again callsthis.save()
, this save call would not work. Entity was still in "processing" state, and method would immediately return.