Rf parallel #20
Merged
Rf parallel #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shacharmo
requested changes
Apr 25, 2021
shacharmo
requested changes
May 3, 2021
|
|
||
|
|
||
| def generate_heat_map(df, number_of_features, hits_data, number_of_samples, output_path): | ||
| train_data = np.log2(df+1) if hits_data else df |
There was a problem hiding this comment.
Same comment as above, this doesn't support p-value correctly
There was a problem hiding this comment.
I thought it was decided after we showed to the client the logs to leave only for hits.
There was a problem hiding this comment.
Even if this is true (and I'm not sure they wanted it for p-val), the p-val has opposite values, i.e. 0 is "best" value
shacharmo
requested changes
May 10, 2021
shacharmo
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.