What to do before 2.x?

[roelvanduijnhoven]

The latest work on Laminas and the bump to PHP >= 7.2 will require a major bump to 2.x.

A good moment to ask ourselves: is there other stuff we want to deprecate or remove at this point?

Do you have thoughts on this @basz, @bakura10?

@bakura10 I also asked you, as you are listed as contributor to this repo at this point :).

[basz]

these come to mind

• deprecate laminas-mvc controller commands, in favour of Symfony commands (see Zend-Expressive - how to run workers SlmQueueDoctrine#150)
• remove support for laminas-service-manager v2 in factories (https://github.com/JouwWeb/SlmQueueDoctrine/blob/master/src/Factory/DoctrineWorkerControllerFactory.php#L31)
• ticks InterruptStrategy.php replace declare ticks with pcntl_signal_dispatch #193
• buryable/releaseable Remove job exception classes (and update the worker) SlmQueueDoctrine#55

[roelvanduijnhoven]

@basz

remove support for laminas-service-manager v2 in factories

I removed the old style factories today!

deprecate laminas-mvc controller commands, in favour of Symfony commands (see Webador/SlmQueueDoctrine#150)

This repo does not use console at all, right? But I agree we can do that in the bump from SlmQueue to SlmQueueDoctrine :).

ticks

Dropped comment in that issue.

buryable/releaseable

That would indeed require a major bump. As would #17. But the gains are also very minimal if you ask me. If you want to do it, feel free, and we can postpone the release. But otherwise I propose we don't block the release on this issue.

Thanks a lot!

[basz]

But otherwise I propose we don't block the release on this issue.

👍

[roelvanduijnhoven]

Feel free to 🚢 @basz. Can do it as well, but since you did the heavy lifting :).