Use optional for speech error enum #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SpeechError` had the same values as `SpeechSynthesisErrorCode` with the addition of a `None` value, to sinalize whether we had an error code set or not. This commit replaces `SpeechError` with the use of `WTF::Optional<SpeechSynthesisErrorCode>` to remove the duplicated information from `SpeechError`. Note: When upstreaming, `WTF::Optional` would be replaced with `std::optional`.
asurdej-comcast
approved these changes
Jun 6, 2022
asurdej-comcast
approved these changes
Jun 6, 2022
Scony
added a commit
to Scony/WPEWebKit
that referenced
this pull request
Mar 21, 2023
- Add missing functions - Add proper error handling (similar to WebPlatformForEmbedded#823 with optional as in WebPlatformForEmbedded#875) for both UIProcess and WebProcess
Scony
added a commit
to Scony/WPEWebKit
that referenced
this pull request
Mar 21, 2023
- Add missing functions - Add proper error handling (similar to WebPlatformForEmbedded#823 with optional as in WebPlatformForEmbedded#875) for both UIProcess and WebProcess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When thinking of upstreaming #863, I realized
SpeechErrorcould be replaced with anOptional<SpeechSynthesisErrorCode>to avoid duplicating the enum values.Note: When upstreaming,
WTF::Optionalwould be replaced withstd::optional.cc @asurdej-comcast