-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decide what to do with the examples/signify-react-ts project #165
Comments
That code was pushed initially to show how can signify-ts be implemented in a web app and because we were having problems running signify in node. As you mentioned is totally outdated. |
I agree that we should keep this example in the codebase. I would be willing to help maintain it. So many recent changes are part of why we haven't updated it. With Phil's recent work #166 being complete then we can have an end-to-end flow with issue, admit, and present so now is a good time to update the webapp. Having a sample one in this repo seems like a good idea and I agree that the tests for this sample app should be run along with tests for the repo. |
Discussed on 12/7 dev call, decision to move to its own repo. |
This is addressed by #170 |
By inspection, I can tell the code in here has not been kept up to date with the recent changes, so it will not work in all scenarios. The
Credentials.tsx
file for example is not updated.Should we keep it? If yes, we probably need to add some steps to the workflow to test that it works. If we do that, we can decide what level to keep it at:
any
types which will effectively turn off typechecking.The text was updated successfully, but these errors were encountered: