Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] When you press "enter" after filling in the Agent URL in the settings it takes you back to the landing page of extension #216

Closed
daidoji opened this issue Nov 6, 2024 · 3 comments
Assignees

Comments

@daidoji
Copy link
Contributor

daidoji commented Nov 6, 2024

To reproduce

  1. New extension loaded from a build of main @ 2799a clean no settings.
  2. Type in a URL to the agentURL box
  3. As soon as you press Enter it takes you back to the landing page of the extension (even though the person probably wants to fill in the settings for the bootURL.

To resolve

Don't go back to landing page until the user clicks "save".

build env

Chrome: Version 130.0.6723.92 (Official Build) (64-bit)
Build Extension from main commit: 2799a16

@HunnySajid
Copy link
Collaborator

can be closed if #219 is merged

@HunnySajid
Copy link
Collaborator

@daidoji can you please provide your feedback and we can close this one if the changes are satsifactory.

@daidoji
Copy link
Contributor Author

daidoji commented Nov 12, 2024

@HunnySajid sure, it seems to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants