Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup logging: logging should consistently use keri.help rather than hio.help #883

Closed
kentbull opened this issue Oct 26, 2024 · 1 comment · Fixed by #896
Closed

Cleanup logging: logging should consistently use keri.help rather than hio.help #883

kentbull opened this issue Oct 26, 2024 · 1 comment · Fixed by #896
Labels
bug Something isn't working triage

Comments

@kentbull
Copy link
Contributor

Version

1.2.0-rc4 (main)

Environment

OSx, Python 3.12.6

Expected behavior

I should be able to control all logging in the application with

from keri import help
logger = help.ogler.getLogger()
logger.setLevel(logging.DEBUG)

Actual behavior

We import from hio as shown below:

form hio import help
logger = help.ogler.getLogger()
logger.setLevel(logging.DEBUG)

Steps to reproduce

in any KLI command import help from hio, get the logger, and set the log level to debug.

If you get the logger from the keri.help package then no log messages show.

@kentbull kentbull added bug Something isn't working triage labels Oct 26, 2024
@kentbull
Copy link
Contributor Author

kentbull commented Dec 3, 2024

#896 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant