Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processCredential telquery messages missing src identifier (fix or remove?) #865

Open
iFergal opened this issue Sep 18, 2024 · 0 comments
Open
Labels
bug Something isn't working triage

Comments

@iFergal
Copy link
Contributor

iFergal commented Sep 18, 2024

Version

1.2.0.dev11 (still there on main)

Environment

No response

Expected behavior

If tel events are missing when processing a credential, the credential is escrowed and a telquery is initiated.

e.g. here

self.cues.append(dict(kin="telquery", q=dict(ri=regk, i=vcid, issr=creder.issuer)))

Given the current code, expected would be the telquery would be sent to the issuer, so the credential can get out of escrow.

However, yesterday we had some discussions on a TEL observer role and in many ways retrieving TELs may vary based on use case and not directly involve the issuer agent, so I wonder if we should remove the telquery and have application specific code decide how to retrieve the TELs if missing?

Actual behavior

Not only should this be pre=creder.issuer instead of issr but even then it's still missing the src field so the WitnessInquisitor doesn't know from which prefix to send the message - see query function here.

Steps to reproduce

I've added an endpoint in KERIA temporarily locally to call processCredential given an ACDC SAD. This happens if I don't do an explicit (properly formed) telquery beforehand.

An easier way might be to comment out the streaming of TEL events when disclosing an ACDC via IPEX: https://github.com/WebOfTrust/keripy/blob/1.2.0-dev11/src/keri/vdr/credentialing.py#L981-L990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant