You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am getting some type errors when running tests on the development branch. I think it is because of recent breaking changes in keripy (WebOfTrust/keripy#633). For example
def test_identifier_collection_end(helpers):
with helpers.openKeria() as (agency, agent, app, client), \
habbing.openHby(name="p1", temp=True) as p1hby, \
habbing.openHby(name="p2", temp=True) as p2hby:
end = aiding.IdentifierCollectionEnd()
resend = aiding.IdentifierResourceEnd()
app.add_route("/identifiers", end)
app.add_route("/identifiers/{name}", resend)
groupEnd = aiding.GroupMemberCollectionEnd()
app.add_route("/identifiers/{name}/members", groupEnd)
client = testing.TestClient(app)
res = client.simulate_post(path="/identifiers", body=b'{}')
assert res.status_code == 400
assert res.json == {'description': "required field 'icp' missing from request",
'title': '400 Bad Request'}
salt = b'012[34](https://github.com/lenkan/keria/actions/runs/7248372481/job/19744152853#step:6:35)[56](https://github.com/lenkan/keria/actions/runs/7248372481/job/19744152853#step:6:57)789abcdef'
serder, signers = helpers.incept(salt, "signify:aid", pidx=0)
assert len(signers) == 1
signer0 = signers[0]
> diger0 = serder.digers[0]
E AttributeError: 'SerderKERI' object has no attribute 'digers'. Did you mean: 'ndigers'?
My current workaround is to pin keripy to a commit from dec 6th. What do you think about pinning the keripy dependency to a commit? Similar to how a package-lock file works in npm.
Workflow for breaking changes to keripy could be something like this:
Commit keripy changes
Locally upgrade keripy dedendency in keria
Run tests, if breaking, make appropriate fixes
Create pull request that contains the updated dependency together with the fixes.
The text was updated successfully, but these errors were encountered:
I am getting some type errors when running tests on the development branch. I think it is because of recent breaking changes in keripy (WebOfTrust/keripy#633). For example
The full run is here: https://github.com/lenkan/keria/actions/runs/7248372481/job/19744152853
My current workaround is to pin keripy to a commit from dec 6th. What do you think about pinning the keripy dependency to a commit? Similar to how a package-lock file works in npm.
Workflow for breaking changes to keripy could be something like this:
The text was updated successfully, but these errors were encountered: